-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Localization cleanup for 3.0 #390
Conversation
matthiasgeiger
commented
Nov 25, 2015
- Adds missing keys to JabRef_en.properties
- Check whether alternative, already existing keys can be reused
- remove obsolete keys
- Cleanup discrepancies listed by mlep
- Add missing keys for all other languages
- Integrate search localizations
- Resort? Non-Empty Alphabetically followed by Empty Alphabetically?
@@ -352,7 +352,7 @@ private void setupLogHandlerForErrorConsole() { | |||
} | |||
session.commit(); | |||
} catch (SaveException ex) { | |||
System.err.println(Localization.lang("Could not save file") + " '" + data[0] + "': " | |||
System.err.println(Localization.lang("Could not save file.") + "\n" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why not use Could not save file %0. to print out the file name as well?
👍 |
@KojiYokota Also added added some missing keys to JabRef_ja.properties. Don't know if that information comes too late. |
@koppor Not a problem - I just wondered why some keys are already present in the Japanese l10n 😉 |
I have looked at the discrepancies between the keys and their English localization. Based on the master branch,
In JabRef_en.properties:
|
Thanks for another few hours work 😉 |
@koppor should be blamed: he is the one pointing me to this thread... 😉 |
a1b02b4
to
6d5a726
Compare
Phewww... should be ready to merge... |
Ahh one thing to be discussed... maybe @mlep can help here: Should we resort the files somehow? All already translated keys to top - all untranslated to the end? Sorting translated/untranslated alphabetically? |
I vote for alphabetically in total. Why:
Btw. nice work here! |
In general I agree, but depending on the workflow of the translaters it might be useful to seperate all untranslated items from the ones already translated... |
I would propose to merge this quickly, as it affects a lot of different lines in the code. And the effort should not be wasted. |
👍 I'll add the remaining German translations directly in |
Localization cleanup for 3.0
To make things easier, when empty keys are added to a file, they are added at the end. This way the translators find them easily (not everybody is using Popeye). |
👍 I would propose to group the entries by usage in the UI, so that related entries are appearing next to each other. I know that this is more difficult to maintain, but more easy for the translators. I think popeye can sort the columns according to empty entries. |
Mhmm... I will not group those ~1500 lines by UI usage 😉 |
Some comments about sorting the keys. |