Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for bug #876: Windows 7/8/10 - Pinning Jabref to the taskbar #40

Closed
wants to merge 0 commits into from

Conversation

tobiasdiez
Copy link
Member

Previously, JabRef couldn't be pinned to the taskbar (bug report). The reason is that, by wrapping JabRef with Launch4j, Windows thinks only Java is running and does not recognize JabRef as something separate.

Based on a stackoverflow question the fix proceeds in two stages:

  • During the setup, we create a (dummy) shortcut and set the Application User Model Id. For this, we use the WinShell plugin for NSIS.
  • At program start, we notify Windows that this JabRef instance has the AppUserModelId specified in the setup. In order to do this, we invoke native commands using the Java Native Access (JNA) library.

@koppor
Copy link
Member

koppor commented May 10, 2015

Thank you for the pull request. My issue is that it includes commits not being related with the fix. The typical way of creating pull requests is to have a separate branch for each pull request. So we can discuss each improvement separately.

The comment is very useful. However, it would be better to place it in the commit message to have it stored in the git repository, too. We have an initial code documentation at https://sourceforge.net/p/jabref/wiki/Development_Howtos/, but I think, that is the wrong place for that.

@tobiasdiez
Copy link
Member Author

I see your point! The other git commits just revert some local changes so that I'm in sync with your repository. All changes in "Files changed" are needed for this fix.
Since I'm new to git, I would welcome if you could provide me tips how I can now remove the unnecessary commits and add the above description to the commit message. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants