A first solution for the cli problem #4038 #4047
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ExportFactory is not initialized at this execution point...
johannes-manner
changed the title
johannes-manner
added
the
status: ready-for-review
|
TL;DR: I guess we should use the second method. Let's see what the others think. I guess the second solution is fine, if not, we will find out. |
stefan-kolb
approved these changes
May 24, 2018
tobiasdiez
approved these changes
May 24, 2018
Merged
Siedlerchr
added a commit
that referenced
this pull request
May 27, 2018
…leType * upstream/master: (33 commits) Import inspection uses now same font size setttings as maintable (#4062) Add date checker (#4007) Enable tests macOs push to application fix Fix #4041 to make Push to Application work again on OSX. (#4057) Add NormalizeEnDashesFormatter (#4045) Package private for tests Shutdown duplicate code Move migrations to PreferencesMigrations Structure startup Extract migrations A first solution for the cli problem #4038 (#4047) New translations JabRef_en.properties (French) (#4052) Update CHANGELOG.md Fix checkstyle Make test more informative in the failing case New translations JabRef_en.properties (French) (#4051) New translations JabRef_en.properties (Vietnamese) (#4050) Make Formatter an abstract class (and remove AbstractFormatter) New Crowdin translations (#4048) ... # Conflicts: # CHANGELOG.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ExportFactory is not initialized at this execution point...
The printUsage method is used twice. The JabRefCLI prints the usage, if an error occurs during argument parsing and the ArgumentProcessor prints the usage, when --help option is chosen.
I made two solutions for this problem:
Commit 1: Some sort of a hack to only get the names of the exporters without altering the processing in the main method.
Commit 2: Changed the order of execution in the main method. The argument processor needs the export factory. I don't know, if the processing of the preferences will influence the cli functionality?
Fixes #4038