Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The textarea in the PersonsEditor is focused when the field is focused #4112

Merged
merged 2 commits into from
Jun 7, 2018
Merged

The textarea in the PersonsEditor is focused when the field is focused #4112

merged 2 commits into from
Jun 7, 2018

Conversation

JavierMF
Copy link
Contributor

@JavierMF JavierMF commented Jun 6, 2018

The first field of the FieldsEditorTab.java is selected on creating for focus, and the textarea inside the PersonsEditor is focused when the field is focused.

fixes #4024

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Siedlerchr
Siedlerchr approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Siedlerchr
Copy link
Member

Thank you very much for your contribution!

tobiasdiez
tobiasdiez approved these changes Jun 7, 2018
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very nice! I added the link to the github issue that is fixed, but apart from this minor detail the PR was perfect ;-). Thanks again for your contribution.

@tobiasdiez tobiasdiez merged commit cc3f7f0 into JabRef:master Jun 7, 2018
@JavierMF JavierMF deleted the fix-for-issue-4024 branch June 7, 2018 08:47
Siedlerchr added a commit that referenced this pull request Jun 8, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into fixdragandrop
236646b 
* upstream/master:
  Mac graphics (#4074)
  The textarea in the PersonsEditor is focused when the field is focused (#4112)
  Fix that sometimes an empty side pane is shown (#4105)
Siedlerchr added a commit that referenced this pull request Jun 13, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into leakedthread
3880225 
* upstream/master:
  Extract v4.x changelog (#4125)
  Saves and reloads window state on close and on open (#4124)
  Fix convert to bibtex moves contents of the file field (#4123)
  Opens the directory of the currently edited file when opening a new file (#4106)
  Show Citation style also in entry preview in preferences (#4121)
  Mac graphics (#4074)
  The textarea in the PersonsEditor is focused when the field is focused (#4112)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

New Entry does no longer focus on first field instead search field is focused
3 participants
@JavierMF @Siedlerchr @tobiasdiez