Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove GlobalFocusListener and old TextField entry editor #4336

Merged
merged 2 commits into from
Sep 12, 2018
Merged

Remove GlobalFocusListener and old TextField entry editor #4336

merged 2 commits into from
Sep 12, 2018

Conversation

tobiasdiez
Copy link
Member

Fixes #4324.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Sep 12, 2018
Siedlerchr
Siedlerchr reviewed Sep 12, 2018
View reviewed changes
src/main/java/org/jabref/gui/JabRefFrame.java
if (focusOwner instanceof TextInputControl) {
// Focus is on text field -> copy/paste/cut selected text
TextInputControl textInput = (TextInputControl) focusOwner;
switch (command) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add a default case in both switches

Siedlerchr
Siedlerchr approved these changes Sep 12, 2018
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just add a default case to the switch and we can merge

@tobiasdiez tobiasdiez merged commit fef1b8a into master Sep 12, 2018
@tobiasdiez tobiasdiez deleted the fix4324 branch September 12, 2018 18:16
Siedlerchr added a commit that referenced this pull request Sep 13, 2018
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into storeColumnSortOrder
3f28f72 
* upstream/master:
  Fix export of corporate author to MSOffice (#4337)
  Added new keyboard shortcut "ctrl+E" for closing the entry editor. (#4222) (#4338)
  Remove GlobalFocusListener and old TextField entry editor (#4336)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tobiasdiez @Siedlerchr