Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix IllegalArgumentException when ranking entries #4779

Merged
merged 3 commits into from
Apr 8, 2019
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -104,6 +104,7 @@ We refer to [GitHub issues](https://github.com/JabRef/jabref/issues) by using `#
- We fixed an issue where only one PDF file could be imported [#4422](https://github.com/JabRef/jabref/issues/4422)
- We fixed an issue where "Move to group" would always move the first entry in the library and not the selected [#4414](https://github.com/JabRef/jabref/issues/4414)
- We fixed an issue where an older dialog appears when downloading full texts from the quality menu. [#4489](https://github.com/JabRef/jabref/issues/4489)
- We fixed an issue where ranking an entry would generate an IllegalArgumentException. [#4754](https://github.com/JabRef/jabref/issues/4754)
- We fixed an issue where special characters where removed from non label key generation pattern parts [#4767](https://github.com/JabRef/jabref/issues/4767)
- We fixed an issue where the RIS import would overwite the article date with the value of the acessed date [#4816](https://github.com/JabRef/jabref/issues/4816)

Expand Down
10 changes: 5 additions & 5 deletions src/main/java/org/jabref/gui/actions/StandardActions.java
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,11 @@ public enum StandardActions implements Action {
QUALITY_ASSURED(Localization.lang("Toggle quality assured"), IconTheme.JabRefIcons.QUALITY_ASSURED),
RANKING(Localization.lang("Rank"), IconTheme.JabRefIcons.RANKING),
CLEAR_RANK(Localization.lang("Clear rank")),
RANK_1("", IconTheme.JabRefIcons.RANK1),
RANK_2("", IconTheme.JabRefIcons.RANK2),
RANK_3("", IconTheme.JabRefIcons.RANK3),
RANK_4("", IconTheme.JabRefIcons.RANK4),
RANK_5("", IconTheme.JabRefIcons.RANK5),
RANK_1(Localization.lang("Set rank to one"), IconTheme.JabRefIcons.RANK1),
RANK_2(Localization.lang("Set rank to two"), IconTheme.JabRefIcons.RANK2),
RANK_3(Localization.lang("Set rank to three"), IconTheme.JabRefIcons.RANK3),
RANK_4(Localization.lang("Set rank to four"), IconTheme.JabRefIcons.RANK4),
RANK_5(Localization.lang("Set rank to five"), IconTheme.JabRefIcons.RANK5),
PRINTED(Localization.lang("Printed"), IconTheme.JabRefIcons.PRINTED),
TOGGLE_PRINTED(Localization.lang("Toggle print status"), IconTheme.JabRefIcons.PRINTED),
READ_STATUS(Localization.lang("Read status"), IconTheme.JabRefIcons.READ_STATUS),
Expand Down
5 changes: 5 additions & 0 deletions src/main/resources/l10n/JabRef_en.properties
Original file line number Diff line number Diff line change
Expand Up @@ -2081,3 +2081,8 @@ Use\ selected\ document=Use selected document
Accept\ changes=Accept changes
Dismiss\ changes=Dismiss changes
The\ library\ has\ been\ modified\ by\ another\ program.=The library has been modified by another program.
Set\ rank\ to\ one=Set rank to one
Set\ rank\ to\ two=Set rank to two
Set\ rank\ to\ three=Set rank to three
Set\ rank\ to\ four=Set rank to four
Set\ rank\ to\ five=Set rank to five