Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed group creation with default settings #4801

Merged
merged 7 commits into from
Apr 7, 2019
Merged

Fixed group creation with default settings #4801

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
db5b44a
Fix for the issue - #4783 Group creation not possible anymore with de…
harinda05 Mar 22, 2019
212170f
resolved conflict in GroupDialog.java
harinda05 Mar 22, 2019
87cdd34
Changed the position of the listeners and onaction replaced with chan…
harinda05 Mar 22, 2019
f50059a
Removed changelog entry
harinda05 Mar 22, 2019
a029969
Merge branch 'master' of git://github.com/JabRef/jabref
harinda05 Mar 26, 2019
01f69c8
Fix for issue 4783 - Simplified listeners in to lambdas
harinda05 Mar 26, 2019
0457ccb
Update GroupDialog.java
tobiasdiez Mar 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/main/java/org/jabref/gui/groups/GroupDialog.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -345,6 +345,10 @@ groupName, getContext(),
return null;
});

nameField.textProperty().addListener((observable, oldValue, newValue) -> updateComponents());
keywordGroupSearchTerm.textProperty().addListener((observable, oldValue, newValue) -> updateComponents());
searchGroupSearchExpression.textProperty().addListener((observable, oldValue, newValue) -> updateComponents());

EventHandler<ActionEvent> actionHandler = (ActionEvent e) -> updateComponents();
nameField.setOnAction(actionHandler);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these obsolete now?

descriptionField.setOnAction(actionHandler);
Expand Down