Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ui preferences global modifications #4926

Merged
merged 20 commits into from Apr 29, 2019
Merged

Ui preferences global modifications #4926

merged 20 commits into from Apr 29, 2019

Conversation

ghost
Copy link

@ghost ghost commented Apr 27, 2019

UI improvements in Preferences tab : General, File, Network, Groups and EntryEditors.
I did some minors adjustments, deleted useless rows, used HBox in the GridPane, moved some separators.

examples :

Preferences -> General Tab BEFORE :

GeneralBefore

Preferences -> General Tab AFTER :

GeneralAfter

Preferences -> Network Tab BEFORE :

NetworkBefore

Preferences -> Network Tab AFTER :

NetworkAfter

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Siedlerchr and others added 18 commits April 25, 2019 22:35
@Siedlerchr @fritz-reynouard
Rework PosteOpenActions to javafx (custom entry type import)
319174d 
Convert dialog for importing custom entry types to CheckListView
Rework threading when opening a database
@Siedlerchr @fritz-reynouard
rework threading stuff
273de83 
simplify code
@Siedlerchr @fritz-reynouard
rework dialog, create fxml etc
6d5e9fd 
fix l10n
Remove obsolete code
@Siedlerchr @fritz-reynouard
remove dialog service argument
2a9d60c
@Siedlerchr @fritz-reynouard
remove dialogService parameter
bf8c037
@CaptainDaVinci @fritz-reynouard
Fixes throwing an exception when 'id' field is present in bib file (#…
2a71a3f 
…4918)

* Fixes throwing an exception when 'id' field is present in bib file

Fixes #4905

* Remove test for id field

* Renamed ID_FIELD to INTERNAL_ID_FIELD

* Removed unused import
@tobiasdiez @fritz-reynouard
Toggle enable status of menu items (#4872)
24bec55 
* Toggle enable status of menu items (prototype)

* Use for pushtoapplication

* Improve code around push to applications

* Set enable status for all actions

* Fix tests and checkstyle
@Siedlerchr @fritz-reynouard
Refactorings, move functionality of CustomEntryTypesManager to Prefer…
632bdf1 
…ences

Use ObservableList instead of LIstProperty
@znuznu @fritz-reynouard
Fix for the issue #4912 (#4916)
0ce291d 
* Fix for the issue #4912

Apostrophe character removed from KEY_ILLEGAL_CHARACTERS in BibtexKeyGenerator

* Add special character to KEY_ILLEGAL_CHARACTERS

ʹ added to KEY_ILLEGAL_CHARACTERS and an assertion has been added in testMakeLabelAndCheckLegalKeysAccentGrave
@fritz-reynouard
Merge branch 'master' of https://github.com/JabRef/jabref
738146c
@fritz-reynouard
Merge branch 'master' of https://github.com/JabRef/jabref
4f796ff
@fritz-reynouard
Preferences->General Tab : UI improvement
69e7874
@fritz-reynouard
Preferences-> General and File tab : UI improvement
c237d0e
@fritz-reynouard
Preferences -> Network tab : UI improvement
051a98b
@fritz-reynouard
Preferences -> Appearance tab : UI improvement
fa82df9
@fritz-reynouard
Prefenrences -> Groups tab : UI improvement
0e97239
@fritz-reynouard
Preferences -> EntryEditors tab : separators readjustment
22accb1
@fritz-reynouard
imports simplification for checkstyle
c125f46
tobiasdiez
tobiasdiez approved these changes Apr 27, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for your PR. It looks indeed way better now!

Siedlerchr
Siedlerchr reviewed Apr 27, 2019
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! I noticed that the entry preview tab, there left list view could also be improved. It takes so much width that the right side is not visible or only after scrolling.
Would you mind fixing that as well?

@ghost
Copy link
Author

ghost commented Apr 28, 2019 •
edited by ghost
Loading

Ok I'll see, but what about the codecov/project? Why does the test fail ?

@Siedlerchr
Copy link
Member

You can ignore that codecov test, it's about how much of the code is covered by tests. But for GUI this is not relevant. The model and logic classes are more important and they are mostly covered.

@tobiasdiez
Copy link
Member

I'll merge this now. Feel more than welcome to create a new PR for further improvements!

@tobiasdiez tobiasdiez merged commit 63634b0 into JabRef:master Apr 29, 2019
Siedlerchr added a commit that referenced this pull request Apr 30, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into swing-test
91e6572 
* upstream/master: (29 commits)
  Improve author parsing (#4931)
  Ui preferences global modifications (#4926)
  Bump checkstyle from 8.19 to 8.20 (#4928)
  Bump mysql-connector-java from 8.0.15 to 8.0.16 (#4924)
  UI Preferences->advanced tab optimization : separators and text modification (#4922)
  Fix for the issue #4912 (#4916)
  Refactorings, move functionality of CustomEntryTypesManager to Preferences Use ObservableList instead of LIstProperty
  Toggle enable status of menu items (#4872)
  Fixes throwing an exception when 'id' field is present in bib file (#4918)
  Quick fix for error when opening preferences (#4917)
  Revert "Create new layout for preferences regarding columns"
  Create new layout for preferences regarding columns
  Rearrange the padding of the "Append library" dialog (#4914)
  Make Group dialog resizable (#4910)
  Adjust save exception to inlcude orgininal stack traces
  remove dialogService parameter
  remove dialog service argument
  rework dialog, create fxml etc fix l10n Remove obsolete code
  rework threading stuff simplify code
  Fix Some Codacy Code Convention Issues (#4904)
  ...

# Conflicts:
#	src/main/java/org/jabref/gui/JabRefFrame.java
#	src/main/java/org/jabref/gui/customentrytypes/FieldSetComponent.java
Siedlerchr added a commit that referenced this pull request May 1, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertSearchWorker
669dc1a 
* upstream/master:
  Throw BibEntryNotFound exception in case entry is no longer present  (#4935)
  Improve author parsing (#4931)
  Ui preferences global modifications (#4926)
  Bump checkstyle from 8.19 to 8.20 (#4928)
  Bump mysql-connector-java from 8.0.15 to 8.0.16 (#4924)
  UI Preferences->advanced tab optimization : separators and text modification (#4922)

# Conflicts:
#	src/main/java/org/jabref/gui/search/SearchWorker.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Siedlerchr @tobiasdiez @CaptainDaVinci @znuznu @fritz-reynouard