Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reformat Understanding the basics section of CONTRIBUTING.md #4978

Merged
merged 2 commits into from
May 18, 2019
Merged

Reformat Understanding the basics section of CONTRIBUTING.md #4978

merged 2 commits into from
May 18, 2019

Conversation

josephshin93
Copy link
Contributor

@josephshin93 josephshin93 commented May 17, 2019 •
edited
Loading

Moved basic steps of the workflow into a numbered listed to clearly express the process, and moved helpful links into specific steps to better associate links with the workflow.

  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

tobiasdiez
tobiasdiez approved these changes May 18, 2019
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes it easier to understand, indeed. Thanks for your contribution!

Siedlerchr
Siedlerchr approved these changes May 18, 2019
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution! Definitely better now.

@Siedlerchr Siedlerchr merged commit 2926705 into JabRef:master May 18, 2019
Siedlerchr added a commit that referenced this pull request May 18, 2019
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into convertSearchWorker
e419b2d 
* upstream/master:
  Fix downloading pdf produces html as extension (#4965)
  Too big error message #4827 (#4966)
  Reformat Understanding the basics section of CONTRIBUTING.md (#4978)
  Revised README.md (#4974)
  Switch Jsoup's StringUtil for JabRef's StringUtil (#4970)
@josephshin93 josephshin93 deleted the inclusivity-fix branch May 19, 2019 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@josephshin93 @Siedlerchr @tobiasdiez