Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicate check on import should be run in background Task #4963 #4981

Merged
merged 9 commits into from
Jun 8, 2019

Conversation

dimmonn
Copy link
Contributor

@dimmonn dimmonn commented May 18, 2019

created background task for the work done in org/jabref/gui/importer/ImportEntriesViewModel.java:68

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label May 19, 2019
container.getChildren().add(1, duplicateButton);
}
Callable<Boolean> hasDuplicateEntryTask = () -> viewModel.hasDuplicate(entry);
BackgroundTask.wrap(hasDuplicateEntryTask).onSuccess(e -> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
BackgroundTask.wrap(hasDuplicateEntryTask).onSuccess(e -> {
BackgroundTask.wrap(viewModel::hasDuplicate).onSuccess(e -> {

or if it's not possible you can inline the callable as folows

Suggested change
BackgroundTask.wrap(hasDuplicateEntryTask).onSuccess(e -> {
BackgroundTask.wrap(()->viewModel.hasDuplicate(entry)).onSuccess(e -> {

}
Callable<Boolean> hasDuplicateEntryTask = () -> viewModel.hasDuplicate(entry);
BackgroundTask.wrap(hasDuplicateEntryTask).onSuccess(e -> {
if (e) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please no single abbrevations, try to specify the result in the variable name, e.g. duplicateFound

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You apparently overlooked this one here

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The approach you took is generally right, but as I answered in the issue, there is the other importEntries function in the viewModel wich also does this check.
Try to find out where it is called (Call Hierachy) and see if that needs also such a Background task

dpolishc added 3 commits May 20, 2019 07:26
@dimmonn
Copy link
Contributor Author

dimmonn commented May 20, 2019

@Siedlerchr thank you for the review, your suggestion is committed, as per call flow I haven't found some bottleneck for viewModel as per call flow if gets called mainly org/jabref/gui/importer/ImportEntriesDialog.java:73

but I guess as you wrote it worth to have this task done in a separate thread for both use cases

optOut -> preferences.setShouldWarnAboutDuplicatesForImport(!optOut));

if (!continueImport) {
dialogService.notify(Localization.lang("Import canceled"));
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is a small problem with the current solution: because the background task is called asynchronously, the importEntries is always called even if there are duplicates. That is the code now runs in the following order: import entries > duplicate check > ask user. But the desired order is duplicate check > ask user > import entries.

Copy link
Contributor Author

@dimmonn dimmonn May 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The importEntries function depends on duplicateCheck from the beginning it seems.

Does it mean the importEntries requires some refactoring so that duplicate check will not be called inside that method, or I took it wrong?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be enough to move the rest of the method up here:

if (!continueImport) {
    dialog.notify(aborted);
} else {
    init file handler
    import();
}

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update. It looks almost good now: the import should also be performed if (preferences.shouldWarnAboutDuplicatesForImport()) returns false and if there is no duplicates (i.e e = false).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, sure

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as abvoe, please no abbreviations like "e" for variables (except for exceptions maybe)

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the follow-up. The code looks very good now and is almost ready to merge. Please change the variable name e (as remarked by Christoph) and move the notification statement, then we can merge.

dialogService.notify(Localization.lang("Import canceled"));
} else {
buildImportHandlerThenImportEntries(entriesToImport);
dialogService.notify(Localization.lang("Number of entries successfully imported") + ": " + entriesToImport.size());
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please move the notify to the end of buildImportHandlerThenImportEntries so that the message is shown in every case after the import.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sure, should be done

Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for your contribution!

@Siedlerchr Siedlerchr merged commit 08388b6 into JabRef:master Jun 8, 2019
github-actions bot pushed a commit that referenced this pull request Aug 23, 2020
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (#4981)
5338ff6 Create electrophoresis.csl (#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (#4927)
d807202 Changes to match Taxon guidelines for authors (#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (#4962)
16f58df Update American Physical Society styles (#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (#4979)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: 469deb6
github-actions bot pushed a commit to RamonG92/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to CaptainDaVinci/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to dimitra-karadima/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to Xuanxuan-Zou/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to felixbohnacker/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to ShikunXiong/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to eetian/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to leitianjian/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to systemoperator/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to dextep/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to graffaner/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to joe9111/jabref that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
github-actions bot pushed a commit to NikodemKch/jabref-1 that referenced this pull request Sep 1, 2020
fad76fe Update Gemfile.lock
a8dafef Update harvard-cite-them-right.csl (JabRef#4993)
c8784ff Update and rename emerald-harvard.csl to emerald-harvard-2.csl (JabRef#4991)
197ec0e Update circulation-journal.csl (JabRef#4994)
f36dabe Update American Physical Society dependents (JabRef#4992)
93469bb Create journal-of-musculoskeletal-research.csl (JabRef#4990)
43287c7 Update taxon.csl a little more (JabRef#4989)
9f32917 Update and rename university-college-lillebaelt-harvard.csl to ucl-un… (JabRef#4982)
00c3cec Update isnad-metinici.csl (JabRef#4988)
864a64c Update medicine-and-science-in-sports-and-exercise.csl (JabRef#4983)
0c76011 Don't demote particles in Equine Vet J (JabRef#4984)
603ee73 Fix MLA editor translator (JabRef#4985)
40d207c Update pravnik.csl (JabRef#4986)
c5fe30c Update isnad-dipnotlu.csl (JabRef#4987)
469deb6 Sage Harvard: Add translator/editor
1f51ef8 Add Pensoft dependents (JabRef#4981)
5338ff6 Create electrophoresis.csl (JabRef#4883)
4de9a97 Update spec_helper.rb
fe81f17 Create uirs-urbani-izziv.csl (JabRef#4928)
69d37d8 Create uirs-urban-challenge-journal.csl (JabRef#4927)
d807202 Changes to match Taxon guidelines for authors (JabRef#4980)
aeb2170 Create ucl-university-college-denmark-apa.csl (JabRef#4962)
16f58df Update American Physical Society styles (JabRef#4794)
b77bd91 Update ucl-university-college-denmark-vancouver.csl (JabRef#4963)
81d1a59 Update bibliotheque-d-archeologie-mediterraneenne-et-africaine-biama.csl (JabRef#4979)
0895562 Create pensoft-journals.csl (JabRef#4972)
4f8fa44 creates the gigascience.csl file (JabRef#4961)
1b9c7a0 Create acta-ornithologica.csl (JabRef#4977)
c8c6c6d Create sorbonne-student-law-review.csl (JabRef#4956)

git-subtree-dir: src/main/resources/csl-styles
git-subtree-split: fad76fe
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants