Add option to allow for integers in field "edition" when running database in bibtex mode #5121
Conversation
There was a problem hiding this comment.
Looks good to me from my point of view
@calixtus As you have been working on the Preferences tab it would be nice if you could look over it, if it's correct
Siedlerchr
added
the
status: ready-for-review
| @@ -78,6 +79,7 @@ public GeneralTabViewModel(DialogService dialogService, JabRefPreferences prefer | |||
| ); | |||
| } | |||
|
|
|||
| @Override | |||
There was a problem hiding this comment.
no need to override for setValues(), storeSettings() or validateSettings(), they directly implement the PrefsTab-Interface
There was a problem hiding this comment.
Oh sorry, this is because of the Eclipse IDE that put this automatically. I will correct this.
|
Ok, i focused on the preference-stuff, made a comment, everything else fits into the pattern, so i guess besides the "Override" - lgtm. |
|
Please fix the changes proposed from @calixtus and merge the latest JabRef master branch in your branch |
Issue #4680
This is a new fork from the old pull request.
I added a checkbox in Preferences/GeneralTab to allow insert integers in field edition when bibtex mode is running. Also, i modified EditionChecker class to permit this configuration. As well as the test cases in IntegrityCheckTest class.