Show more than one group color bar #5356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Shows multiple colored bars if the entry belongs to more than one group (with color). Implements #4574.
tobiasdiez
added
the
status: ready-for-review
matthiasgeiger
approved these changes
Sep 26, 2019
|
|
||
| if (!groupColors.isEmpty()) { | ||
| HBox container = new HBox(); | ||
| container.setSpacing(2); | ||
| container.setMinWidth(10); | ||
| container.setAlignment(Pos.CENTER); |
There was a problem hiding this comment.
Is it possible to set it to left align? Looks better imho 😀
There was a problem hiding this comment.
Good idea, but now I cannot decide what I prefer 😸
Left-aligned
Right-aligned
or the centered version from above...?!
There was a problem hiding this comment.
I would still say left aligned... But that's just my personal opinion 😁
|
+1 for left-aligned. If one does not know the feature, this looks better to me. Anything else left? |
|
ok, left aligned it is. Ready to merge from my POV. |
koppor
removed
the
status: ready-for-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Shows multiple colored bars if the entry belongs to more than one group (with color). Implements #4574.
