Conversion of prefs/bibtexkeygen and appearance to mvvm

[calixtus]

follow up to #5033

Besides converting the two tabs I added a fancy little line at the top of the button bar, so the sidepane does not hang in the air anymore.

---

• Change in CHANGELOG.md described
• Tests created for changes
• Manually tested changed features in running JabRef
• Screenshots added in PR description (for bigger UI changes)
• Ensured that the git commit message is a good one
• Check documentation status (Issue created for outdated help page at help.jabref.org?)

[calixtus]

Added screenshots.

This PR should be somewhat done, although the bibtexKeyPatternPanel (shared between the prefs and the libraryPrefs) needs to be converted to mvvm too. Should I do this in this PR or leave it for now?

[Siedlerchr]

some minor things

[tobiasdiez]

Nice work. I've only a few remarks concerning the code and a couple of suggestions for the UI of the bibtex key pattern tab:

• Give the three options (letter a, letter b, always append) a heading and indent the radiobuttons. Moreover, I suspect that always one option need to be selected. At least the code

  jabref/src/main/java/org/jabref/logic/bibtexkeypattern/BibtexKeyGenerator.java

  Lines 169 to 190 in bbf3ab4

  	String newKey;
  	if (!alwaysAddLetter && (occurrences == 0)) {
  	newKey = key;
  	} else {
  	// The key is already in use, so we must modify it.
  	int number = !alwaysAddLetter && !firstLetterA ? 1 : 0;
  	String moddedKey;
  	do {
  	moddedKey = key + getAppendix(number);
  	number++;
  	occurrences = database.getDuplicationChecker().getNumberOfKeyOccurrences(moddedKey);
  	// only happens if #getAddition() is buggy
  	if (Objects.equals(oldKey, moddedKey)) {
  	occurrences--;
  	}
  	} while (occurrences > 0);
  	newKey = moddedKey;
  	}
  	return newKey;

  always adds something if there are duplicate keys.
• Indent the text field below "replace"
• Change "Special key patterns" to "Key patterns" (as there is nothing special about them or do I miss something?)
• Not sure how this looks, but I would put the default key pattern first and separately from the other entry-type dependent patterns (most users probably only change the default pattern, so this is the most important option). In addition, maybe give the other patterns a heading (e.g. entry type specific patterns).

[calixtus]

WIP again, I started converting BibtexKeyPatternPanel to mvvm. I decided to implement it as a table, as it was in fact a table with a lot of textfields and annyoing buttons. Not working yet entirely, but I have to take a break. Uploaded it for you to see some progress.

[calixtus]

Some progress, there is still something wrong with the saving of the default pattern. I kept the former panel for the library options, converting them should not be much work.

If not sorted (also after three clicks), the highlighted default column stays always on the top of the list and is always somewhat purple, except if it's selected. I think this is probably a compromise between cleaning up and eye-catching the default pattern.

As soon as this is done, you can put a final x in #3861 😄

[calixtus]

Sooooo, after a while some updates. I think I'm finally done with the preferenceTabs. However, if you open one small issue, an abyss of possible tasks opens in front of you. But one after another.

I have left the bibtexKeyPatternPanel in for the library-properties. Converting this can be easily done by another PR as the BibtexKeyPatternTableView is reusable, but I was too exhausted to do that now (It would also go somewhat beyond this PR).

I'm not really sure about binding the ListProperty out of one TableViewModel into the TabViewModel. I was experimenting with possible solutions, but could not really find one, which would not break the mvvm-pattern. I would be happy if you got some better ideas.

Now I'm looking forward for your suggestions and your critics.
Ready for review again.

[tobiasdiez]

Thanks for the follow-up! Looks good to me now.

Any ideas what you want to work on now? If not https://github.com/JabRef/jabref/milestone/18 might give you some inspiration (once these last issues are fixed, we can release 5.0!)

[calixtus]

Thanks for the follow-up! Looks good to me now.

Any ideas what you want to work on now? If not https://github.com/JabRef/jabref/milestone/18 might give you some inspiration (once these last issues are fixed, we can release 5.0!)

You're welcome.

About whats next: As soon as i've got some time I probably take a look at the release-blocking tasks you mentioned. I can understand that bugfixing is now more important towards releasing 5.0 but including new features. But what is really important but is not yet listed: Documentation. We should not forget about this.

Btw. I just saw that I forgot to reimplement the help-button of the keypattern table. Will be the first thing tomorrow. 😅

After all of that, I'm going to return to my agenda, I already put up here: #5315 (comment)

[calixtus]

Hm, travis somehow cannot install openjdk-12...

[Siedlerchr]

Seems like you're not alone. I saw in the travis forum that the issue is also with version 11 apparently
Hopefully only a temporary problem