Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix postrm in deb #5455

Merged
merged 1 commit into from
Oct 17, 2019
Merged

Fix postrm in deb #5455

merged 1 commit into from
Oct 17, 2019

Conversation

LyzardKing
Copy link
Collaborator

@LyzardKing LyzardKing commented Oct 16, 2019

An error in the postrm file could prevent reinstalls

Remove the associations file and set in .desktop
(Avoid having another extra file for a single line declaration)

Manually set license/copyright for deb (rpm in gradle):
(The parsing of the license.md file is not working consistently)


  • Change in CHANGELOG.md described
  • Tests created for changes
  • Manually tested changed features in running JabRef
  • Screenshots added in PR description (for bigger UI changes)
  • Ensured that the git commit message is a good one
  • Check documentation status (Issue created for outdated help page at help.jabref.org?)

Manually set license/copyright for deb (rpm in gradle)
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you please report these problem also to the jpackage devs.

@LyzardKing
Copy link
Collaborator Author

The postrm error was my fault, the copyright issue is reported upstream regarding the fact that it doesn't copy to the DEBIAN folder, I'll follow up with another email asking about the format of the license file, but I haven't heard back yet.
https://mail.openjdk.java.net/pipermail/core-libs-dev/2019-October/062905.html

@Siedlerchr Siedlerchr merged commit 26a1d29 into JabRef:master Oct 17, 2019
@Siedlerchr
Copy link
Member

@LyzardKing Just a reminder, you can directly create branches at the jabref upstream repo. You have push rights. So no need to work in your fork ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants