Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix destination for jabref mozilla json #5503

Merged
merged 2 commits into from
Oct 27, 2019
Merged

Fix destination for jabref mozilla json #5503

merged 2 commits into from
Oct 27, 2019

Conversation

LyzardKing
Copy link
Collaborator

Fixes #5502
I'd keep the branch open, to enable test builds of deb/rpm packages while we fix the last jpackage options.

@Siedlerchr
Copy link
Member

Ah shit, oss.sonatype maven repo once again is down...

@LyzardKing
Copy link
Collaborator Author

It managed to build locally and went down just as I pushed the change upstream...

@LyzardKing
Copy link
Collaborator Author

@Siedlerchr I forced the build to run again, since the repo is up now.
Once it's built let me know if you can test it!

@koppor
Copy link
Member

koppor commented Oct 27, 2019

@LyzardKing What testing do you mean? None of us has Linux machines :(

If you say, it's good to go, we can merge!

@LyzardKing
Copy link
Collaborator Author

It should be fine.
Just to be on the safe side I'll try rebasing on master so I can test the deb first

@koppor
Copy link
Member

koppor commented Oct 27, 2019

Seeing #5502, @Siedlerchr is our linux tester. 🎉

@Siedlerchr
Copy link
Member

Seeing #5502, @Siedlerchr is our linux tester. 🎉

You wish. Nope, I have only a slow Ubuntu VM (running on my hdd cause my ssd is too small) for testing stuff.

@LyzardKing
Copy link
Collaborator Author

Seeing #5502, @Siedlerchr is our linux tester. tada

You wish. Nope, I have only a slow Ubuntu VM (running on my hdd cause my ssd is too small) for testing stuff.

😄

I tested on a live image with no jabref version, with the version in the ubuntu repo and reinstalling the deb.
The install seems to never fail and copies the proper json file.
@Siedlerchr if you want to test it to be sure, then you're free to merge

@tobiasdiez tobiasdiez merged commit fa25ee9 into master Oct 27, 2019
@tobiasdiez tobiasdiez deleted the debRpmInstall branch October 27, 2019 21:33
@LyzardKing
Copy link
Collaborator Author

LyzardKing commented Oct 27, 2019

That was fast..
@tobiasdiez I would have kept the branch, to test the deb, since the licence/copyright stuff is still missing.. But we can open a new one once we figure it out
Regarding that, I have never had a reply on the mailing list..

@tobiasdiez
Copy link
Member

Yeah, you are not alone. I've also send a few mails to the jdk mailing list and didn't get a single response yet.
The license stuff is not super important so I guess it is fine to wait until jpackage is released and properly documented.

(the branches are deleted automatically btw)

@LyzardKing
Copy link
Collaborator Author

LyzardKing commented Oct 27, 2019

Ah ok.. sorry
The rest of the deb should work..and the license in the rpm should (in theory) work
since it's set in a separate command..
But I'll test that tomorrow in a vm ;)

@Siedlerchr
Copy link
Member

Works fine now.

@LyzardKing
Copy link
Collaborator Author

🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error installing jabref deb package in ubuntu: native messaging host is not a dir
4 participants