Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reorderable columns in maintable for groups, URI, file and eprint #5544

Merged
merged 17 commits into from
Nov 10, 2019
+691 −592
Merged

Reorderable columns in maintable for groups, URI, file and eprint #5544

Changes from 1 commit
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
2136362
Initial
calixtus Oct 29, 2019
9759a5a
Added combined identifier column
calixtus Oct 30, 2019
8fb708b
Removed superfluous properties
calixtus Oct 30, 2019
090fe51
Added display names and refactored
calixtus Nov 1, 2019
bf4b02e
Fixed persistent state
calixtus Nov 1, 2019
7a5a09f
changelog
calixtus Nov 1, 2019
8edfbe0
Added columns to available set
calixtus Nov 1, 2019
59551c0
checkstyle
calixtus Nov 1, 2019
18af535
Fixed bug in persistent view
calixtus Nov 1, 2019
f94f87e
Refactored parse, rewording, cleanups
calixtus Nov 2, 2019
0a4e3f7
Removed TableColumnsItemModel, cleanups
calixtus Nov 3, 2019
ae0821b
Added migration and some minor tweaks
calixtus Nov 3, 2019
e9caf51
Removed superfluous method getHeaderLabel
calixtus Nov 3, 2019
63333d6
Merge remote-tracking branch 'upstream/master' into maintable_columns…
calixtus Nov 3, 2019
dd01025
Cleanups, seperating specialFieldsPreferences, added width-binding
calixtus Nov 4, 2019
68119ec
Refactored according to remarks
calixtus Nov 4, 2019
e34cbee
Added Tests
calixtus Nov 4, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
checkstyle
@calixtus
calixtus committed Nov 1, 2019
commit 59551c09226de3631541d3f4d166ef12c66d5c85
1 change: 0 additions & 1 deletion src/main/java/org/jabref/gui/preferences/TableColumnsTabViewModel.java
View file
Original file line number Diff line number Diff line change
@@ -103,7 +103,6 @@ public void setValues() {
availableColumnsProperty.add(new MainTableColumnModel(MainTableColumnModel.Type.NORMALFIELD, InternalField.TYPE_HEADER.getName()));
availableColumnsProperty.add(new MainTableColumnModel(MainTableColumnModel.Type.LINKED_IDENTIFIER));


EnumSet.allOf(StandardField.class).stream()
.map(Field::getName)
.map(name -> new MainTableColumnModel(MainTableColumnModel.Type.NORMALFIELD, name))