Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve check list #5587

Merged
merged 4 commits into from
Nov 22, 2019
Merged

Improve check list #5587

Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
10982a3
Make checklist more prominent
koppor Nov 10, 2019
29ea54b
Remove git commit message check
koppor Nov 10, 2019
b63d9a2
Merge branch 'master' into improve-checklist
koppor Nov 22, 2019
8548700
Result of devcall
koppor Nov 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 15 additions & 7 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,12 +1,20 @@
<!-- describe the changes you have made here: what, why, ...
Link issues by using the following pattern: [#333](https://github.com/JabRef/jabref/issues/333) or [koppor#49](https://github.com/koppor/jabref/issues/47).
The title of the PR must not reference an issue, because GitHub does not support autolinking there. -->
<!--
Describe the changes you have made here: what, why, ...
Link issues by using the following pattern: #333.
If you fixed a koppor issue, link it with following pattern: [koppor#47](https://github.com/koppor/jabref/issues/47).
The title of the PR must not reference an issue, because GitHub does not support autolinking there.
-->

## Checklist
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The body of the PR is always the most important one, thus I don't like the heading here as it puts too much emphasize on something relatively unimportant.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wanted the thing to be more intuitively separated. Using -- it always felt a bit off. I wondered whether we should add a section ## Description


----
<!--
- All items with `[ ]` are still a TODO.
- All items checked with `[x]` are done.
- Remove item not applicable
-->

- [ ] Change in CHANGELOG.md described
- [ ] Tests created for changes
- [ ] Manually tested changed features in running JabRef
- [ ] Change in CHANGELOG.md described (if applicable)
- [ ] Tests created for changes (if applicable)
- [ ] Manually tested changed features in running JabRef (always required)
- [ ] Screenshots added in PR description (for bigger UI changes)
- [ ] [Checked documentation](https://docs.jabref.org/): Is the information available and up to date? If not: Issue created at <https://github.com/JabRef/user-documentation/issues>.