Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When using the builder of BibEntry, the entry should not be mod… #5635

Merged
merged 1 commit into from
Nov 18, 2019

Conversation

koppor
Copy link
Member

@koppor koppor commented Nov 18, 2019

Minor code quality things.

  • Ensure that BibEntry#withField keeps hasChanged() == false
  • Refine comment and add empty lines in BibDatabase.java
  • Fix semantic of variable in SaveDatabaseActionTest (it really points to a file, not to a directory)

@koppor koppor force-pushed the fix-changed-flag branch 2 times, most recently from 28cd410 to c499daf Compare November 18, 2019 21:30
- Ensure that `BibEntry#withField` keeps `hasChanged() == false`
- Refine comment and add empty lines in BibDatabase.java
- Fix semantics of variable in SaveDatabaseActionTest (it really points to a file, not to a directory)
@koppor koppor changed the title When using the builder of BibEntry, the entry should not be modified When using the builder of BibEntry, the entry should not be mod… Nov 18, 2019
@koppor koppor merged commit 347b5e8 into master Nov 18, 2019
@koppor koppor deleted the fix-changed-flag branch November 18, 2019 21:57
@koppor koppor mentioned this pull request Nov 18, 2019
1 task
koppor pushed a commit that referenced this pull request Oct 1, 2021
3b00357 Update urad-rs-za-makroekonomske-analize-in-razvoj.csl (#5639)
fcf6625 updated styles (#5638)
0df0633 Update universite-du-quebec-a-montreal-etudes-litteraires-et-semiolog… (#5614)
eaddf8e Human Molecular Genetics (#5635)
0afd7fb Update harvard-cardiff-university.csl (#5623)
f424672 Switch ISQ to Chicago author-date
ccb7184 Update chicago-author-date.csl (#5605)
a408957 SBL: implementation of book reviews (#5613)
fbbe7b3 Update harvard-swinburne-university-of-technology.csl to meet published spec (#5627)
8d7a0d8 Add UNESCO IIEP style (#5631)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 3b00357
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants