Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] UI consistency polish #5737

Closed
wants to merge 5 commits into from

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Dec 11, 2019

Some looks and some behaviour of JabRef are not consistent or not intuitive.
This PR should equalize some of it.

As standard behaviour and look, I'm using the protected terms dialog (it already was like this before I came to JabRef) [on the left] and the special name formatters tab in the preferences [on the right].
protected terms special name formatters


I started by fixing some malfunctioning keyEvents in the preferences and the view of the StringEditorDialog.
string constant old string constant new
(left old - right new)

More to come. Suggestions? Critics?

Hopefully after this PR is done, some Screenshots can be taken for the documentation.

@tobiasdiez
Copy link
Member

It's definitely a good idea to make the UI more uniform. Your changes also look good to me.

The only thing where I'm unsure is about the best way to add new rows. The two options are:

  1. Button below the table that inserts a new empty row, which then can be changed by the user (old behavior of StringEditorDialog)
  2. Text fields below the table with a button that adds the input as a new row (current behavior of special name formatters tab)

I find option 1 a bit more intuitive if the data does not require complex validation, there are only a few columns and the input is really a 1:1 version of the table data.

What's the recommendation of our UI expert @MartinKarim?

@calixtus
Copy link
Member Author

I agree that adding a new line by option 1 is somehow more intuitive. However, I decided to go for the second option, because I had problems to distinguish between a new cell and the empty space below. This is probably an issue about the cellfactory or the theme.
I will try to refine a prototype to compare.

@tobiasdiez
Copy link
Member

In the ideal case, the newly created row is selected and put in edit mode automatically, so that the user can start typing immediately.

@calixtus
Copy link
Member Author

I looked into this a bit. The obstacle is, that the textfield in the edit cell is not accessible, so it can request the focus. This means that I have to create a custom implementation of the edit cell. I think I've seen this already somewhere else in the codebase, so it's not infernal stuff.
Maybe I'll find some time for that at Christmas.

@tobiasdiez
Copy link
Member

You might be able to get the text field using Node.lookup(...).

@calixtus
Copy link
Member Author

calixtus commented Jan 1, 2020

Happy new year. I've cherrypicked the important commits into another branch, but was unfortunately not able to merge the latest master into the branch, which is the basis for this PR. So i'm going to close this PR, work on the other branch and create another PR after my oral exams in the end of january.

@calixtus calixtus closed this Jan 1, 2020
@calixtus calixtus deleted the ui_consistency_polish branch January 1, 2020 11:21
koppor pushed a commit that referenced this pull request Dec 1, 2021
3bb4b5f infoclio.ch styles for German: remove non-breaking space delimiters (#5754)
adf28db Create journal-of-health-care-for-the-poor-and-underserved.csl (#5752)
0713a8e Update chinese-gb7714-2005-numeric.csl (#5737)
1cd3754 Update china-national-standard-gb-t-7714-2015-author-date.csl (#5746)
c2536b7 Update china-national-standard-gb-t-7714-2015-numeric.csl (#5745)
f8c1392  Create steel-research-international.csl (#5720)
21fe1f5 Create asian-myrmecology.csl (#5718)
91e9e2b Update harvard-university-of-the-west-of-england.csl (#5734)
dd453d1 fix minor erros in polar-research.csl (#5730)
038a8f5 Remove group around no-date cluster (#5731)
0710b51 remove et-al from bibtex.csl (#5728)
bbd703d Add editorial-director to universite-laval-departement-des-sciences-historiques.csl (#5727)
58ea430 Create german-journal-of-agricultural-economics.csl (#5717)
0654e16 Create scandinavian-journal-of-information-systems.csl (#5716)
ce2d537 Update journal-of-computer-applications-in-archaeology.csl (#5715)
755d3d3 Create human-rights-law-review.csl (#5626)
0feda94 Create journal-of-intercultural-studies.csl (#5709)
ae4756d Update acta-universitatis-agriculturae-sueciae.csl (#5713)
323d9ac Update mohr-siebeck-recht.csl (#5559)
15530a8 Bch corr (#5712)
094a1af Create forschungsjournal-soziale-bewegungen-fjsb.csl (#5699)
cb91566 initialize authors and editors (#5714)
2d5cfff Create cancer-biomarkers.csl (#5703)
5e264d5 Update multidisciplinary-digital-publishing-institute.csl (#5708)
46e961f Create klinische-padiatrie.csl (#5711)
e81e877 Create bulletin-archeologique-des-ecoles-francaises-a-l-etranger.csl (#5704)
0029c5a Create polar-research.csl 🧊 (#5702)
7db1361 Update vancouver-imperial-college-london.csl (#5641)
b953e9f Update iso690-author-date-fr-no-abstract.csl (#5706)
91eda8c Update thieme-german.csl (#5710)
ebe0787 Update harvard-imperial-college-london.csl (#5643)
2d4db76 Fix UNESCO IIEP in text
436cbf4 Create revue-archeologique-de-narbonnaise.csl (#5688)
5150bcf Create journal-of-computer-assisted-tomography.csl (#5690)
dd6f050 Create anti-trafficking-review.csl (#5658)
08e622f Create the-angle-orthodontist.csl (#5685)
c6a1907 journal-of-palm-oil-research.csl fix several errors (#5686)
6cbe29d Create bern-university-of-applied-sciences-school-of-agricultural-for… (#5684)
f590dc1 Update biomed-central.csl (#5701)
1efce81 Update turabian-author-date.csl (#5695)
12dbba5 Create tyndale-bulletin (#5673)
b0746db Create Engineered Regeneration (#5682)
e38b953 wikipedia citation template (#5662)
5e7f731 Create early-music-history.csl (#5679)
86443f3 Create zeitschrift-fur-politik.csl (#5676)
68f1996 Create annals-of-work-exposures-and-health.csl (#5666)
1ba9dc6 Create brazilian-journal-of-psychiatry.csl (#5672)
438f92c fix error for speech in ama styles (#5693)
7a0c2d3 set initialize-with-hyphen to false (#5689)
3bd2765 Update emu-austral-ornithology.csl (#5671)
31492b2 fix various errors in natura-croatica.csl (#5687)
94d6b23 Update iso690-author-date-cs.csl (#5677)
5d017da minor update on the "Haute école de gestion de Genève - ISO 690" style (#5665)
2cad8f6 add ibid/subsequent to comparative-politics.csl (#5669)
de0b116 Create taylor-and-francis-vancouver-national-library-of-medicine.csl (#5650)
ed87f99 Update bulletin-de-correspondance-hellenique.csl (#5663)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 3bb4b5f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants