Fixes problems with managing external file types (issue 5846) #5894

systemoperator · 2020-01-29T14:55:04Z

Fixes #5846

Changed:

edit/customize external file types: radio button for "default program"/"custom program" fixed: They now get updated and set properly (binding added and setting values).
"Edit file type" dialog: correct value gets loaded now for the input field "Name"
when updating an external file type entry: no differentiation will be made anymore whether the program runs on Windows or somewhere else
Everything concerning the type CustomExternalFileType is now working properly as well.
- Settings will also be saved to JabRef's config.xml file.
Editing an entry with type ExternalFileType works now as well. (changes are not lost anymore)
- Settings will also be saved to JabRef's config.xml file.

Remarks:

Table in "Manage external file types" dialog is "lazily" updated when a table entry has been updated. (But this seems to be a Linux issue anyway, since other tables behave the same way.)

Tasks:

Change in CHANGELOG.md described
Manually tested changed features in running JabRef (always required)
Checked documentation: Is the information available and up to date?

systemoperator · 2020-01-29T18:27:53Z

The last commit is a quick fix and could be improved, since the old table entry gets replaced by a new one, even if the user would then cancel the process of editing the entry. Nevertheless, even if the user cancelled the edit process, everything is still fine and valid.

Editing external file types is now fully functional. No problems are known. Suggestions are welcome.

The line fileTypesTable.refresh(); has no effect, since the "lazy" update of the table does not change by using it. But this could be a Linux issue anyway, since other tables behave the same way. Thus, I could remove the line.

calixtus · 2020-01-29T21:21:40Z

Thanks for the fix @systemoperator.
I took a quick peek into the code, there seems to be something wrong with the branch head. Git wants to merge a lot of additions to the csl-styles. I'm not really into git, but maybe a rebase on the current upstream/master can clear that. Just a wild guess.

systemoperator · 2020-01-29T21:27:16Z

Yes, I have noticed this as well. github actions "did" that. It's the first time, that I have seen that, but I am new here anyway, so I don't know whether this occurs sometimes and it is fine or not. The good thing is, that there are no merge conflicts. Maybe @tobiasdiez can have a look at this.

calixtus · 2020-01-30T21:49:35Z

Hey @systemoperator, got a hint by @koppor. This might help solving the branch issue with your PR:

https://lostechies.com/joshuaflanagan/2010/09/03/use-gitk-to-understand-git/

koppor · 2020-01-30T22:05:43Z

You can create one single commit containing your changes with following commands:

Ensure that your workdirectory is clean (git shows now changes)
gitk --all -- just keep it opened until the end. Then, you can always revert to a state you did some reset steps.
git checkout fix-for-issue-5846
git fetch --all
git merge upstream/master (and commit the merge!)
git reset upstream/master
Commit as usual
git push -f

Assumption: git remote add upstream https://github.com/JabRef/jabref.git was done sometime ago. You can check with git remote -v.

…am"/"custom program" fixed: it now gets updated properly (binding added); - "Edit file type dialog": correct value get loaded now for the input field "Name" - when storing an updated file type: no differentiation will be made any more whether program runs on Windows or somewhere else - quick fix for pending issue: editing an ExternalFileType works now (still room for improvement); visual bug concerning "lazy" update of table could be a Linux issue, since other tables are affected as well; so basically - except the "lazy" update thing -- everything works concerning external file types

tobiasdiez

Thanks for your PR. The changes look good to me. I've one remark concerning the introduction of the custom application property, which I don't think is necessary.

src/main/java/org/jabref/gui/externalfiletype/EditExternalFileTypeEntryDialog.java

tobiasdiez · 2020-01-31T11:45:37Z

src/main/java/org/jabref/gui/externalfiletype/CustomizeExternalFileTypesDialog.java

@@ -40,6 +40,7 @@ public CustomizeExternalFileTypesDialog() {
        this.setResultConverter(button -> {
            if (button == ButtonType.OK) {
                viewModel.storeSettings();
+                fileTypesTable.refresh();


If it does not work, then you can delete this indeed.

systemoperator · 2020-02-01T10:36:39Z

For testing purposes, I made some changes in EditExternalFileTypeEntryDialog.fxml (in the src/main.../gui/... directory) but when I built and ran the project with the changes, then those changes did not show up in the corresponding dialogue.

My questions are:

What needs to be done, so that changes in those files will update the corresponding GUI element?
Do you use some graphical tool to change these files?

calixtus · 2020-02-01T10:55:30Z

Are the multiple changes to authors.md really intended?

systemoperator · 2020-02-01T11:00:35Z

Yes, I simply ran the script scripts/generate-authors.sh, to pull in new authors.

calixtus · 2020-02-01T11:12:51Z

Theres something odd: Igor Steinmacher appears in full name as well in concatenaded form (also Oscar Gustafsson ) Maybe you've configured git to return only nicknames instead of full names?

Siedlerchr · 2020-02-01T12:36:27Z

You don't need to run the script manually. We will do this from time to time or at least in preparation for a release

systemoperator · 2020-02-01T12:38:57Z

Theres something odd: Igor Steinmacher appears in full name as well in concatenaded form (also Oscar Gustafsson )

Maybe he commited with his username first and later on with his real name. Nevertheless, this will always reappear by running the script. But I could now remove the entry with his username?

I did it, because it is mentioned in the docs, that one can do it. And I wanted to try it. :)

tobiasdiez · 2020-02-01T16:35:24Z

@koppor what is our policy concerning this? (which then should be clarified in the docs)

As these changes are not directly related to the main theme of this PR, can you please remove these changes for now so that we can merge? Thanks

koppor · 2020-02-01T22:58:40Z

We maintain the .mailmap to always map to the full name. I don't get, why is Oscar and Igor appear with their short names at your system. Have to try it here locally

Typically, we update the AUTHORS file now and then. Especially before a release. (See https://github.com/JabRef/jabref/wiki/Releasing-a-new-Version)

I also thought to setup a GitHub action to comment at the PR with the new entry in the AUTHORS file. Should be doable...

calixtus · 2020-02-01T23:33:24Z

Maybe a quick fix to get this PR mergable: leave your name in authors.md and remove the other additions, they will be put in before release.

systemoperator · 2020-02-01T23:41:43Z

done

tobiasdiez · 2020-02-02T09:47:15Z

Thanks again for contribution, and sorry for the confusion caused. I hope the additional effort on your side wasn't too great. Your next PR should go more smoothly 😄

* upstream/master: Fixes problems with managing external file types (issue 5846) (#5894) Squashed 'src/main/resources/csl-locales/' changes from 41da445acc..4fa753374e Squashed 'src/main/resources/csl-styles/' changes from f0c7374..e71363e

* upstream/master: reference to issue added (#5911) Fix properly resolves OrFields of required fields (#5903) IDE setup updated and extended (#5901) Squashed 'src/main/resources/csl-styles/' changes from e71363e..c531528 Fixes problems with managing external file types (issue 5846) (#5894) Squashed 'src/main/resources/csl-locales/' changes from 41da445acc..4fa753374e Squashed 'src/main/resources/csl-styles/' changes from f0c7374..e71363e Update development-strategy.md

* master: reference to issue added (#5911) Fix properly resolves OrFields of required fields (#5903) IDE setup updated and extended (#5901) Squashed 'src/main/resources/csl-styles/' changes from e71363e..c531528 Fixes problems with managing external file types (issue 5846) (#5894) Squashed 'src/main/resources/csl-locales/' changes from 41da445acc..4fa753374e Squashed 'src/main/resources/csl-styles/' changes from f0c7374..e71363e Update development-strategy.md Replace link to Workspace set-up with new one (#5896) Fixes making paths of linked files relative (web urls will not be touched anymore) (#5879)

eb97405 Create frattura-ed-integrita-strutturale-fracture-and-structural-inte… (#5877) b33ebfc make journal names title case (#5900) 1c7ecf2 Update uclouvain-centre-charles-de-visscher-pour-le-droit-internation… (#5901) 1a2ea12 Create trinity-college-dublin-zoology-botany-environmental-sciences-h… (#5893) 6bd742c Update harvard-anglia-ruskin-university.csl (#5840) bc8f258 Update chicago-author-date.csl (#5836) 80aded6 Fix missing prefix for URL field (#5894) b850a0d Update american-society-of-civil-engineers.csl (#5891) 94c1cb3 Update deutsche-gesellschaft-fur-psychologie.csl (#5861) f66f384 Update universite-cheikh-anta-diop-faculte-de-medecine-de-pharmacie-et-dodontologie.csl (#5863) 82cf786 Update and rename acta-psychiatrica-scandinavica.csl to dependent/acta-psychiatrica-scandinavica.csl (#5879) git-subtree-dir: buildres/csl/csl-styles git-subtree-split: eb97405

systemoperator changed the title ~~[WIP] Addresses problems with managing external file types (issue 5846)~~ Addresses problems with managing external file types (issue 5846) Jan 29, 2020

systemoperator changed the title ~~Addresses problems with managing external file types (issue 5846)~~ Fixes problems with managing external file types (issue 5846) Jan 29, 2020

systemoperator requested a review from Siedlerchr January 29, 2020 18:19

koppor force-pushed the master branch from f53568b to 8fb37b6 Compare January 30, 2020 21:46

systemoperator force-pushed the fix-for-issue-5846 branch from f37df3f to cb497fb Compare January 30, 2020 23:28

tobiasdiez requested changes Jan 31, 2020

View reviewed changes

cleanup + changelog

25285b9

revert authors

8dc7d1c

tobiasdiez merged commit 78f7d65 into JabRef:master Feb 2, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fixes problems with managing external file types (issue 5846) #5894

Fixes problems with managing external file types (issue 5846) #5894

systemoperator commented Jan 29, 2020 •

edited

Loading

systemoperator commented Jan 29, 2020 •

edited

Loading

calixtus commented Jan 29, 2020

systemoperator commented Jan 29, 2020 •

edited

Loading

calixtus commented Jan 30, 2020

koppor commented Jan 30, 2020 •

edited

Loading

tobiasdiez left a comment

tobiasdiez Jan 31, 2020

systemoperator Jan 31, 2020

systemoperator commented Feb 1, 2020

calixtus commented Feb 1, 2020

systemoperator commented Feb 1, 2020 •

edited

Loading

calixtus commented Feb 1, 2020 •

edited

Loading

Siedlerchr commented Feb 1, 2020

systemoperator commented Feb 1, 2020

tobiasdiez commented Feb 1, 2020

koppor commented Feb 1, 2020

calixtus commented Feb 1, 2020

systemoperator commented Feb 1, 2020

tobiasdiez commented Feb 2, 2020

Fixes problems with managing external file types (issue 5846) #5894

Fixes problems with managing external file types (issue 5846) #5894

Conversation

systemoperator commented Jan 29, 2020 • edited Loading

systemoperator commented Jan 29, 2020 • edited Loading

calixtus commented Jan 29, 2020

systemoperator commented Jan 29, 2020 • edited Loading

calixtus commented Jan 30, 2020

koppor commented Jan 30, 2020 • edited Loading

tobiasdiez left a comment

Choose a reason for hiding this comment

tobiasdiez Jan 31, 2020

Choose a reason for hiding this comment

systemoperator Jan 31, 2020

Choose a reason for hiding this comment

systemoperator commented Feb 1, 2020

calixtus commented Feb 1, 2020

systemoperator commented Feb 1, 2020 • edited Loading

calixtus commented Feb 1, 2020 • edited Loading

Siedlerchr commented Feb 1, 2020

systemoperator commented Feb 1, 2020

tobiasdiez commented Feb 1, 2020

koppor commented Feb 1, 2020

calixtus commented Feb 1, 2020

systemoperator commented Feb 1, 2020

tobiasdiez commented Feb 2, 2020

systemoperator commented Jan 29, 2020 •

edited

Loading

systemoperator commented Jan 29, 2020 •

edited

Loading

systemoperator commented Jan 29, 2020 •

edited

Loading

koppor commented Jan 30, 2020 •

edited

Loading

systemoperator commented Feb 1, 2020 •

edited

Loading

calixtus commented Feb 1, 2020 •

edited

Loading