Solved #593 and cleaned up the OO-code a bit #594
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oscargus
added
openoffice/libreoffice
status: ready-for-review
oscargus
force-pushed
the
ooreferencelist
branch
from
86038f0
to
37421b2
Compare
oscargus
added
bug
oscargus
force-pushed
the
ooreferencelist
branch
2 times, most recently
from
11201a7
to
57930ea
Compare
oscargus
force-pushed
the
ooreferencelist
branch
from
57930ea
to
861951d
Compare
|
Looks good. Is it possible, that the dependency on "unoil.jar" can be removed? |
|
unOil.jar was in a separate directory before (changing the default paths to be the same for unOil and the other jars, where jurt.jar is the one searched for, was the biggest change to get it to work with the most recent versions of OO and LO). |
koppor
added a commit
that referenced
this pull request
Dec 27, 2015
Solved #593 and cleaned up the OO-code a bit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hopefully solved #593.
Try it out at http://builds.jabref.org/ooreferencelist/
(Also cleaned up the code a bit based on PMD. The actual fix is on lines 76-90 in OOUtil.java.)