-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SonarCloud Trigger #5995
Add SonarCloud Trigger #5995
Conversation
b360cdf
to
0649f2b
Compare
I still have to see valuable recommendations from these static code analyzers, but well let's try another one ;-) Why is this PR needed? It appears that sonarcloud is already posting to PRs (which is a bit annoying to be honest, would have preferred a github action) |
I'm also against using them. They have more false positives than valuable recommendations. Annoying |
I agree that the comments are annoying. We are trying to turn them off. Nevertheless having all tools running enables JabRef being part of teaching Software Engineering. For instance, statement such as "more false positives than valuable recommendations" can be quantified when a) the analysis results are available and b) results of other products are available. Otherwise, that statement makes an impression to me made out of the blue based on other experiences, but not with the current code at hand. |
Kudos, SonarCloud Quality Gate passed! 0 Bugs |
Because of https://community.sonarsource.com/t/disable-github-merge-request-comments/18520/19, I will not go forward. (PR commenting cannot be disabled) Ticket https://jira.sonarsource.com/browse/SCCOMM-19 - please vote for it 🎉 |
SonarCloud offers great code quality analysis. This PR enables it.
Refs #5991