Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raise codecov threshold #6027

Merged
merged 3 commits into from
Feb 27, 2020
Merged

Raise codecov threshold #6027

merged 3 commits into from
Feb 27, 2020

Conversation

stefan-kolb
Copy link
Member

Often PRs are red because of minimal threshold changes below 1 percent

image

Often PRs are red because of minimal threshold changes below 1 percent
@stefan-kolb stefan-kolb added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 26, 2020
@koppor
Copy link
Member

koppor commented Feb 27, 2020

I fully agree that CodeCov is annoying for small changes. However, if someone adds code, CodeCov should immediately say that no test cases are added.

Couldn't we use 0.05 or something like that (0.1)?

@stefan-kolb
Copy link
Member Author

I fully agree that CodeCov is annoying for small changes. However, if someone adds code, CodeCov should immediately say that no test cases are added.

Couldn't we use 0.05 or something like that (0.1)?

Not sure if percentages below 1 percent are allowed: https://docs.codecov.io/docs/commit-status

@LinusDietz
Copy link
Member

To be honest, I'm not sure if we should tinker with this.

  • In case of any PR that does not affect the test coverage (build-related, translations, csl, etc.) codecov is meaningless anyways.
  • In all other cases, it might serve as a reminder that adding tests might be a good idea.

@stefan-kolb
Copy link
Member Author

To be honest, I'm not sure if we should tinker with this.

  • In case of any PR that does not affect the test coverage (build-related, translations, csl, etc.) codecov is meaningless anyways.
  • In all other cases, it might serve as a reminder that adding tests might be a good idea.

It just marks the whole PR as red which is not what I want as an indicator all the time.

image

@koppor
Copy link
Member

koppor commented Feb 27, 2020

I hope, that the datatype float allows for expressing numbers between 0 and 1:

Quoting https://docs.codecov.io/docs/commit-status:

grafik

Numbers are "normal" percentage. Meaning 1 is 100%: https://community.codecov.io/t/threshold-confusion/88/2

@JabRef JabRef deleted a comment from codecov bot Feb 27, 2020
@codecov
Copy link

codecov bot commented Feb 27, 2020

Codecov Report

❗ No coverage uploaded for pull request base (master@74667e9). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master   #6027   +/-   ##
========================================
  Coverage          ?   41.5%           
  Complexity        ?    6868           
========================================
  Files             ?    1085           
  Lines             ?   46406           
  Branches          ?    5574           
========================================
  Hits              ?   19263           
  Misses            ?   25698           
  Partials          ?    1445

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 74667e9...80ee204. Read the comment docs.

@koppor koppor merged commit 2fad020 into master Feb 27, 2020
@koppor koppor deleted the codecov-threshold branch February 27, 2020 19:09
@koppor koppor removed the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Feb 27, 2020
Siedlerchr added a commit that referenced this pull request Mar 6, 2020
* upstream/master:
  Remove "Merge Entries" from Quality Menu (#6021)
  Raise codecov threshold (#6027)
  Translation for SpecialField names in preferences (#6031)
  Fix dependency updates workflow (#6033)
  Add graal info to module file (#6010)
  Group remote database actions in menu
  Move journal abbreviations to quality
koppor pushed a commit that referenced this pull request Apr 25, 2022
76b4268 Style for Acta Physica Sinica (物理学报) (#6009)
604de6f MLA Publication Date update (#5927)
41ce2d4 Update netherlands-journal-of-geosciences-geologie-en-mijnbouw.csl (#6027)
ad08f5d Adds space after title writing in ABNT style file (#6031)
0b5c1c2 Create CRCAO Light (#5935)
2f42b8c Create annals-of-laboratory-medicine.csl (#5959)
80a9506 Create annual-review-of-linguistics (#5992)
0fb9c40 Update the-journal-of-egyptian-archaeology.csl (#6028)
5ff53b1 Update guide-des-citations-references-et-abreviations-juridiques.csl (#6002)
c1c0212 Update society-for-american-archaeology.csl (#5919)
129ef3c Update administrative-science-quarterly.csl (#5991)
8bc22bd Create multilingual-matters.csl (#5955)
aca84fd Create expert-reviews-in-molecular-medicine.csl (#5961)
3c4ddc0 Create ethnobiology-letters.csl (#5986)
c301e04 Update heidelberg-university-faculty-of-medicine.csl (#5932)
a8c4396 Update tyndale-bulletin.csl (#5949)
c18cbcf Bluebook hotfix
d950b2b  Create incontext-studies-in-translation-and-interculturalism.csl (#5907)
7cfc106 Bump nokogiri from 1.13.2 to 1.13.4 (#6016)
0baa43a Liebert update (#6026)
41ca2b3 Bluebook Add space for ibid  (#6025)
6707a37 Update american-journal-of-botany.csl (#5954)
926fad5 Update boletin-de-pediatria.csl (#6024)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 76b4268
Jonathan-Oliveira pushed a commit to Jonathan-Oliveira/jabref that referenced this pull request May 7, 2022
76b4268 Style for Acta Physica Sinica (物理学报) (JabRef#6009)
604de6f MLA Publication Date update (JabRef#5927)
41ce2d4 Update netherlands-journal-of-geosciences-geologie-en-mijnbouw.csl (JabRef#6027)
ad08f5d Adds space after title writing in ABNT style file (JabRef#6031)
0b5c1c2 Create CRCAO Light (JabRef#5935)
2f42b8c Create annals-of-laboratory-medicine.csl (JabRef#5959)
80a9506 Create annual-review-of-linguistics (JabRef#5992)
0fb9c40 Update the-journal-of-egyptian-archaeology.csl (JabRef#6028)
5ff53b1 Update guide-des-citations-references-et-abreviations-juridiques.csl (JabRef#6002)
c1c0212 Update society-for-american-archaeology.csl (JabRef#5919)
129ef3c Update administrative-science-quarterly.csl (JabRef#5991)
8bc22bd Create multilingual-matters.csl (JabRef#5955)
aca84fd Create expert-reviews-in-molecular-medicine.csl (JabRef#5961)
3c4ddc0 Create ethnobiology-letters.csl (JabRef#5986)
c301e04 Update heidelberg-university-faculty-of-medicine.csl (JabRef#5932)
a8c4396 Update tyndale-bulletin.csl (JabRef#5949)
c18cbcf Bluebook hotfix
d950b2b  Create incontext-studies-in-translation-and-interculturalism.csl (JabRef#5907)
7cfc106 Bump nokogiri from 1.13.2 to 1.13.4 (JabRef#6016)
0baa43a Liebert update (JabRef#6026)
41ca2b3 Bluebook Add space for ibid  (JabRef#6025)
6707a37 Update american-journal-of-botany.csl (JabRef#5954)
926fad5 Update boletin-de-pediatria.csl (JabRef#6024)

git-subtree-dir: buildres/csl/csl-styles
git-subtree-split: 76b4268
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants