Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix import into current library issuing wrong message #6269

Merged
merged 3 commits into from
Apr 13, 2020
Merged

Fix import into current library issuing wrong message #6269

merged 3 commits into from
Apr 13, 2020

Commits on Apr 10, 2020

  1. Fix import into current library issuing wrong message (JabRef#6266) 

    This change fixes JabRef#6266 in which an erroneous message "import cancelled" is displayed when importing into the current library. This fix was accomplished by modifying the parameter of the extends clause of the ImportEntriesDialog class to have a return type of Boolean rather than Void and making setResultConverter return false rather than null.
    @jcampbell11245
    jcampbell11245 committed Apr 10, 2020
    Configuration menu
    Copy the full SHA
    0338e1d View commit details
    Browse the repository at this point in the history

Commits on Apr 13, 2020

  1. Reformat ImportEntriesDialog and Fix setResultConverter return value … 

    …in FindUnlinkedFilesDialog

I have added back the proper indentation for line 79 of ImportEntriesDialog and changed the return value to Boolean and returned false in FindUnlinkedFilesDialog.
    @jcampbell11245
    jcampbell11245 committed Apr 13, 2020
    Configuration menu
    Copy the full SHA
    ecc4a39 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into fix-for-issue-6266

    @Siedlerchr
    Siedlerchr authored Apr 13, 2020
    Configuration menu
    Copy the full SHA
    14770db View commit details
    Browse the repository at this point in the history