Improve performance massively by fixing a stupid binding mistake

[tobiasdiez]

There was a really stupid mistake in the way the main table was set up: the bindings for converting the raw field value to the proper displayed representation were created in the setCellValueFactory.

jabref/src/main/java/org/jabref/gui/maintable/FieldColumn.java

Line 33 in 5ed32e1

setCellValueFactory(param -> getColumnValue(param.getValue()));

jabref/src/main/java/org/jabref/gui/maintable/FieldColumn.java

Line 50 in 5ed32e1

return Bindings.createStringBinding(() -> computeText(entry), dependencies);

This has the consequence that whenever the table view asked for the current value a new binding was created and the value was re-calculated over and over again. For example, if there were to the entry list then the table view asks all entries if their values changes. Usually only a couple of entries are changed, so that only these entries need to be redrawn. But since the binding was re-created, actually all entries were redrawn instead.
Moreover, since every call to cell value factory created a new binding, a new invalidation listener was added to fields every time, leading to really high numbers of a few thousand invalidation listeners.
I really hate myself for this stupid implementation 🙈 .

This PR fixes this problem by simply creating the bindings for each entry once, and then reuse. This lead to a massive performance increase as well as a huge memory consumption improvement. For example, sorting and filtering using groups in @AEgit huge database is now almost instant. Moreover, the memory is down from 2gb to a bit more than 1gb (this tells you how many useless invalidation listeners were there before).

Should fix the renaming issues in #5071. Might fix #5919 as well as #5735.

• Change in CHANGELOG.md described (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

[Siedlerchr]

Will test this, but Code wise looks good!
Kudos for spotting and fixing the bug!

[Siedlerchr]

Startup still takes some time, but it's already faster than before with the huge database.