Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option #6330

Merged
merged 5 commits into from
Apr 21, 2020
Merged

'Name' textfield on focus instead of 'OK' button when user clicks on 'Add subgroup' option #6330

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d54cdc4
Name field now in focus whenever 'add subgroup' button selected
HussainArif12 Apr 20, 2020
6eecc15
Updated: Focuson Name Area instead of 'OK' button whenever user press…
HussainArif12 Apr 20, 2020
f4e1785
Focus on name text area whenever user clicks on Add Subgroup
HussainArif12 Apr 20, 2020
3172b9d
Focus on name text area when OK button is pressed
HussainArif12 Apr 20, 2020
94beba5
Fixed changelog.md
HussainArif12 Apr 21, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
- We added a 'LaTeX citations' tab to the entry editor, to search for citations to the active entry in the LaTeX file directory. It can be disabled in the preferences dialog.
- We added an option in preferences to allow for integers in field "edition" when running database in bibtex mode. [#4680](https://github.com/JabRef/jabref/issues/4680)
- We added the ability to use negation in export filter layouts. [#5138](https://github.com/JabRef/jabref/pull/5138)
- Focus on Name Area instead of 'OK' button whenever user presses 'Add subgroup'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add a link to the issue like in the other lines


### Fixed

Expand Down
1 change: 1 addition & 0 deletions src/main/java/org/jabref/gui/groups/GroupDialogView.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -142,6 +142,7 @@ public void initialize() {
validationVisualizer.initVisualization(viewModel.keywordRegexValidationStatus(), keywordGroupSearchTerm);
validationVisualizer.initVisualization(viewModel.keywordSearchTermEmptyValidationStatus(), keywordGroupSearchTerm);
validationVisualizer.initVisualization(viewModel.keywordFieldEmptyValidationStatus(), keywordGroupSearchField);
nameField.requestFocus();
});

// Binding to the button throws a NPE, since it doesn't exist yet. Working around.
Expand Down