Fix library sort order get lost

[hrandrianasolo]

This PR fixes #6091

Co-authored-by: Heriniaina Randrianasolo hjsrandrianasolo@gmail.com
Co-authored-by: Omar Tachour omar.tchr@hotmail.com
Co-authored-by: Sadji Micipsa micipsasadji@gmail.com

This error is due to the absence of an object equality test for the saveInSpecifiedOrder attribute.
So we have handled this error by correcting the equals function in the SaveOrderConfig class.

• Change in CHANGELOG.md described (if applicable)
• Tests created for changes (if applicable)
• Manually tested changed features in running JabRef (always required)
• Screenshots added in PR description (for UI changes)
• Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

[Siedlerchr]

Your changes look good to me, but I'm currently trying to understand why this fixes the error. Could you please explain that in a bit more detail?

[Siedlerchr]

@hrandrianasolo I tested your changes and they don't seem to make a difference. So could you please explain it

[Hugoo98]

hi @Siedlerchr
we apologize for the delay, I am the colleague of @hrandrianasolo, the bug correction works very well on a version which is not up to date.
We have well compiled and executed the modified code and we found that the bug is corrected, there I am trying to test it on the new version.
Regarding the explanation, the configuration of the export sort order is represented by the class SaveOrderConfig, in LibraryPropertiesDialogView there are two objects of type SaveOrderConfig:
→ oldSaveOrderConfig: represents the old configuration,
→ newSaveOrderConfig: represents the new configuration.
We compare the equality of its last two to see if a change has been made or not. After several tests, we realized that the equals function in saveOrderConfig did not take into account the equality of all attributes.

[Hugoo98]

Hi @Siedlerchr I inform you that I tried our correction on today's version it also worked !!

[hrandrianasolo]

Hi, everyone, sorry for the delay. As my colleague explained above regarding the explanation of the fix, I put here screenshots of the bug fix instead of the screen recorder because I can't put it in the comments.

[Siedlerchr]

Thanks for the explanation. LGTM

[koppor]

We merge to get things moving forward.

We will add the CHANGELOG.md change by ourselves.