Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for exception thrown if no delimiters were specified #6642

Merged
merged 5 commits into from
Jul 5, 2020
Merged

Fix for exception thrown if no delimiters were specified #6642

merged 5 commits into from
Jul 5, 2020

Conversation

alex-petrov-vt
Copy link
Contributor

@alex-petrov-vt alex-petrov-vt commented Jun 26, 2020

Assigned default values for delimiters to fix the exception thrown
Fixes #6624

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

… default

values to base and hierarchical delimiters
@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jun 27, 2020
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR!

Could you also add a CHANGELOG.md entry, too?

Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a suggestion reusing an existing constant.

When this is changed, this is good to go.

We don't have a constant for ,. In case you want to work on the code quality of JabRef, this would be a good thing to start with...

Maybe even make the default delimiter configurable in the preferences.

@koppor
Copy link
Member

koppor commented Jul 3, 2020

I commited my update. The required "import" is not added. Maybe, someone can add it. Otherwise, I'll try to find time on the weekend and go ahead with merging; this is some kind of hotfix and should go in early.

@Siedlerchr Siedlerchr merged commit 817c768 into JabRef:master Jul 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

exception when filling new group dialog wrongly
3 participants