-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix for exception thrown if no delimiters were specified #6642
Conversation
… default values to base and hierarchical delimiters
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR!
Could you also add a CHANGELOG.md
entry, too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a suggestion reusing an existing constant.
When this is changed, this is good to go.
We don't have a constant for ,
. In case you want to work on the code quality of JabRef, this would be a good thing to start with...
Maybe even make the default delimiter configurable in the preferences.
I commited my update. The required "import" is not added. Maybe, someone can add it. Otherwise, I'll try to find time on the weekend and go ahead with merging; this is some kind of hotfix and should go in early. |
Assigned default values for delimiters to fix the exception thrown
Fixes #6624