Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete link after download #6723

Merged
merged 2 commits into from
Aug 4, 2020
Merged

Delete link after download #6723

merged 2 commits into from
Aug 4, 2020

Conversation

tobiasdiez
Copy link
Member

Fixes #6588.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@tobiasdiez tobiasdiez added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Jul 28, 2020
koppor
koppor reviewed Jul 29, 2020
View reviewed changes
Copy link
Member

@koppor koppor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In this case, I like the traditional style to check more. Code proposal inside.

src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java Outdated Show resolved Hide resolved
src/main/java/org/jabref/gui/fieldeditors/LinkedFileViewModel.java Show resolved Hide resolved
@tobiasdiez tobiasdiez added this to the v5.1 milestone Jul 29, 2020
@koppor
Copy link
Member

koppor commented Aug 1, 2020

Replaced Optional<Integer> by int as we directly operate on the list and do not use the full power of Optiona..

@tobiasdiez
Copy link
Member Author

I don't really think that the new version is much more readable, but ok...

@koppor
Copy link
Member

koppor commented Aug 4, 2020

@koppor Please test

  1. Pre-condition: Entry with link (in the file field)
  2. Right-click: download
  3. Link should be replaced

@koppor
Copy link
Member

koppor commented Aug 4, 2020

Tried it out locally. Works.

grafik

@koppor koppor merged commit 2917cab into master Aug 4, 2020
@koppor koppor deleted the removeLinkDownload branch August 4, 2020 22:14
Siedlerchr added a commit that referenced this pull request Aug 9, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into annotationProcessor
e158be2 
* upstream/master: (47 commits)
  Fix copy pasting and delete via menu or key (#6740)
  Add instructions how to work with fetchers  (#6731)
  Autoinstall extension in chrome (#6442)
  Delete link after download (#6723)
  New translations JabRef_en.properties (Portuguese, Brazilian) (#6728)
  Bump pascalgn/automerge-action from v0.8.5 to v0.9.0 (#6736)
  Bump byte-buddy-parent from 1.10.13 to 1.10.14 (#6733)
  Bump mockito-core from 3.4.4 to 3.4.6 (#6734)
  Bump unirest-java from 3.8.06 to 3.9.00 (#6735)
  Bump org.beryx.jlink from 2.21.1 to 2.21.2 (#6732)
  Add testing interface, including a set of capabilities to tests for (#6687)
  Fix pasting on mac and linux (#6419)
  Add validation of "AUTHORS" file (#6722)
  Squashed 'src/main/resources/csl-styles/' changes from cacc4ee..827b986
  New Crowdin updates (#6721)
  Add missing AUTHORs
  Fix for issue 6639 (#6719)
  Fix more links
  Fix link
  New Crowdin updates (#6718)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@koppor koppor koppor left review comments

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
v5.1
Development

Successfully merging this pull request may close these issues.

Delete online link after download
2 participants
@tobiasdiez @koppor