[WIP] Add DOI matching with not full coincidence. #6756
Conversation
Add zero weights for otes and comments.
KunAndrew
force-pushed
the
fix-for-issue-6707
branch
2 times, most recently
from
c8bea4d
to
6c8b7d7
Compare
| @@ -234,6 +234,12 @@ public String getNormalized() { | |||
| return doi; | |||
| } | |||
|
|
|||
| public boolean isCompareNotExact(DOI o2) { | |||
| String s1 = this.doi.replaceAll("[^\\w]", ""); | |||
There was a problem hiding this comment.
why is the "replace" here necessary? Maybe it would be worthwhile to add it to the other cleanup that's already happing in the constructor?
There was a problem hiding this comment.
Yes, maybe it is. I decided to do in this way in order to divide logics of creature, comparison and inaccurate comparison of DOI. This is associated with task context. The DOI standart is not strictly defined. Some special characters can serve as indicators or as special symbols.
There was a problem hiding this comment.
@KunAndrew Can you add a test for this?
We agree that the DOI standard is vague at some places. However, in the concrete case, only white spaces are replaced.
Whitespace in aribtrary locations lead to a non-found doi.
Proposed solution: Can you put that cleanup into the constructor the next two weeks? 😇
Siedlerchr
added
the
status: changes required
small improvements
|
@KunAndrew How is the status here? Is this ready for review? It woud be really cool to have this, it's a massive improvement! |
Moving cleanup's logic to DOI constructor.Add results of generate-authors.sh.
|
Sorry for the long wait. |
|
Please check the work of scripts/generate-authors.sh. I distrust the result. |
|
Thanks for the update. |
Moving cleanup's logic to DOI constructor.Add results of generate-authors.sh. (revert AUTHORS)
|
I reverted the AUTHORS. I upgraded project from github. Then I merged in master (on my local machine) and pushed to remoted. But I have problem with resolving problems. "These conflicts to complex to resolve in the web editor." How should I do it? Should I create a new Pull Request (from my master-branch) and close the current one? |
|
@KunAndrew The best thing is to do this on the command line. You need to merge in the upstream the master branch from the jabref repository..
If you happen to have still some problems or don't feel confident enough I can take over and do the conflict resolving |
|
Yes, that would be great. I don't feel confident enough with git GUI. |
Add DOI matching with not full coincidence.
"Improvement of Duplicate Detection #6707"
Fixes #6707