Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix HTML chars formatter for percent sign #6760

Merged
merged 2 commits into from
Aug 15, 2020
Merged

Fix HTML chars formatter for percent sign #6760

merged 2 commits into from
Aug 15, 2020

Conversation

Vince250598
Copy link
Contributor

@Vince250598 Vince250598 commented Aug 12, 2020 •
edited by Siedlerchr
Loading

Fixes #6753

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@tobiasdiez
Copy link
Member

Thanks for your fix! The changes look good to me. Could you please add a change log entry, and add a few tests to https://github.com/JabRef/jabref/blob/master/src/test/java/org/jabref/logic/layout/format/HTMLCharsTest.java.

@koppor the validate authors workflow is failing. Can you please have a look!

@tobiasdiez tobiasdiez added status: changes required Pull requests that are not yet complete status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Aug 13, 2020
@Siedlerchr Siedlerchr changed the title fix for issue 6753 Fix HTML chars formatter for percent sign Aug 13, 2020
Siedlerchr
Siedlerchr approved these changes Aug 13, 2020
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, your changes look good!

@Siedlerchr Siedlerchr merged commit 1f6604d into JabRef:master Aug 15, 2020
@koppor
Copy link
Member

koppor commented Aug 17, 2020

@tobiasdiez Fixed in f2c8748. Reason was unescaped backtick and quotes in the message output. Refs #6722. I did not test my review-updates properly.

Siedlerchr added a commit that referenced this pull request Aug 19, 2020
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into macsign
39a6b1c 
* upstream/master:
  Fix HTML chars formatter for percent sign (#6760)
  Squashed 'src/main/resources/csl-styles/' changes from d23a3ab..eb0d37e
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: changes required Pull requests that are not yet complete status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Problems for preview of an entry with % sign in title
4 participants
@Vince250598 @tobiasdiez @koppor @Siedlerchr