-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/use unkown fields as default fields #6847
Feature/use unkown fields as default fields #6847
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just quickly went through. Think, there are more commits in here than the title suggests.
/** | ||
* Represents the result of fetching the results from all active fetchers for a specific query. | ||
*/ | ||
public class QueryResult { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Convert to a Java 14 record?
https://dzone.com/articles/a-first-look-at-records-in-java-14
* This class defines all aspects of a scientific study relevant to the application. It is a proxy for the file based study definition. | ||
*/ | ||
public class Study { | ||
private static final String STUDY_ENTRY_NAME = "study"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please introocude a new class "SystematicLiteratureReviewStudyEntryType" (or similar) in the package org.jabref.model.entry.types
and rewort the code accordingly.
); | ||
|
||
testCrawler.performCrawl(); | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Insert an assertion that this does not throw anny assertion. (So that this test gets at least one assertion)
when(preferences.getEncoding()).thenReturn(null); | ||
when(preferences.takeMetadataSaveOrderInAccount()).thenReturn(true); | ||
BibEntryTypesManager entryTypesManager = new BibEntryTypesManager(); | ||
Crawler testCrawler = new Crawler(Paths.get("C:\\Users\\Dominik\\Documents\\Studium\\Informatik Semester 8 Uni Stuttgart\\Bachelorarbeit\\TestStudyRepository"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think, this introduces a dependency to an external repository. I can creawte https://github.com/jabref/jabref-slr-test-repository - and we add a git submodule here.
Alternatively, the test reposiory is created at the start of the cralwer test @Before
. 1. create git repository in temp dir, 2. add files from src/test/resources
, ...
Signed-off-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
13d90c0
to
0df7981
Compare
Hotfix, thus merging in. Future work: Add a test case covering the new "default" branch. |
…-issue-6707 * upstream/master: (35 commits) Fix a fetcher test for the ShortDOIService (#6945) Fixes Shared Database: Changes filtering in CoarseChangeFilter to attribute property (#6868) Changed default value of "search and store files relative to bibtex file" to true (#6928) Replace comment by just a failure (#6943) Fix: in entry types editor selected field is not removed after first click (#6941) Fix remove actions for entry types in the editor (#6933) Always use Java 15 (#6929) Update DevDocs: workaround for issues with local openjfx maven libraries (#6931) Fixes bugs in the `regex` cite key pattern modifier (#6893) Add missing author Readability for citation key patterns (#6706) Add new author Reset to master and add default case to switch (#6847) Bump mockito-core from 3.5.10 to 3.5.11 (#6924) Bump byte-buddy-parent from 1.10.14 to 1.10.15 (#6923) Bump org.beryx.jlink from 2.21.4 to 2.22.0 (#6925) Bump xmpbox from 2.0.20 to 2.0.21 (#6926) Bump pascalgn/automerge-action from v0.9.0 to v0.10.0 (#6927) Improve parsing of short DOIs (#6920) Bump junit-vintage-engine from 5.6.2 to 5.7.0 (#6910) ...
* upstream/master: (55 commits) Rename menus citation style in preview style (#6899) Fix for some Unicode characters in citation keys (#6938) Add missing authors Fix a fetcher test for the ShortDOIService (#6945) Fixes Shared Database: Changes filtering in CoarseChangeFilter to attribute property (#6868) Changed default value of "search and store files relative to bibtex file" to true (#6928) Replace comment by just a failure (#6943) Fix: in entry types editor selected field is not removed after first click (#6941) Fix remove actions for entry types in the editor (#6933) Always use Java 15 (#6929) Update DevDocs: workaround for issues with local openjfx maven libraries (#6931) Fixes bugs in the `regex` cite key pattern modifier (#6893) Add missing author Readability for citation key patterns (#6706) Add new author Reset to master and add default case to switch (#6847) Bump mockito-core from 3.5.10 to 3.5.11 (#6924) Bump byte-buddy-parent from 1.10.14 to 1.10.15 (#6923) Bump org.beryx.jlink from 2.21.4 to 2.22.0 (#6925) Bump xmpbox from 2.0.20 to 2.0.21 (#6926) ... # Conflicts: # src/main/java/org/jabref/logic/util/DelayTaskThrottler.java
This PR adds the unknown fielded terms as default phrases.
This is a follow up on #6805.