Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix INSPIRE fetcher and short doi fetcher tests #6975

Merged
merged 2 commits into from
Oct 4, 2020
Merged

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Oct 3, 2020

Arxiv Test is failing with the search phrase, because both queries return the same result.

@DominikVoigt In ArxivTest supportsPhraseSearch(), both queries return the same result. Maybe you can take a look at that

      List<BibEntry> resultWithPhraseSearch = fetcher.performSearch("au:\"Tobias Diez\"");
        List<BibEntry> resultWithOutPhraseSearch = fetcher.performSearch("au:Tobias Diez");
  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Arxiv Test is failing with the search phrase, because both queries return the same result
@Siedlerchr Siedlerchr added fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers labels Oct 3, 2020
@@ -64,7 +64,7 @@
+ "(" // begin group \1
+ "10" // directory indicator
+ "[/%:]" // divider
+ "[a-zA-Z0-9]{4,}" // at least 4 characters
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed at #6977

@DominikVoigt DominikVoigt mentioned this pull request Oct 4, 2020
5 tasks
* upstream/master:
  Pin application insights (#6972)
  Adapt the short DOI regex (#6977)
  Fix the paths in chrome snap hooks (#6978)
  Adapt test
@Siedlerchr Siedlerchr merged commit d371fde into master Oct 4, 2020
@Siedlerchr Siedlerchr deleted the fixFetcher branch October 4, 2020 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fetcher status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants