-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/add abstract field to complex search #7079
Merged
calixtus
merged 3 commits into
JabRef:master
from
DominikVoigt:feature/add-abstract-field-to-complex-search
Nov 7, 2020
Merged
Feature/add abstract field to complex search #7079
calixtus
merged 3 commits into
JabRef:master
from
DominikVoigt:feature/add-abstract-field-to-complex-search
Nov 7, 2020
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
…act-field-to-complex-search
koppor
requested changes
Nov 6, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small nitpick comment
src/main/java/org/jabref/logic/importer/fetcher/ComplexSearchQuery.java
Outdated
Show resolved
Hide resolved
src/main/java/org/jabref/logic/importer/fetcher/ComplexSearchQuery.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
koppor
approved these changes
Nov 6, 2020
calixtus
approved these changes
Nov 7, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Two approvals -> I think I'll merge this. |
Siedlerchr
added a commit
to koppor/jabref
that referenced
this pull request
Nov 11, 2020
* upstream/master: (164 commits) Bump lucene-queryparser from 8.6.3 to 8.7.0 (JabRef#7089) Fix endnote importer when keyword style is null (JabRef#7084) Rename Firefox extension file in Windows (JabRef#7092) Add support for Microsoft Edge browser in Windows and Linux builds (JabRef#7056) Bump unirest-java from 3.11.03 to 3.11.05 (JabRef#7087) Bump com.github.ben-manes.versions from 0.33.0 to 0.36.0 (JabRef#7088) Bump gittools/actions from v0.9.4 to v0.9.5 (JabRef#7091) Feature/add abstract field to complex search (JabRef#7079) Add missing authors Implement Emacs key bindings (JabRef#6037) Special field code maintenance (JabRef#7078) Follow up fix for 7077 Reset preview layouts on clear Fix preview settings not saved due to l10n (JabRef#7077) Add link to existing documentation of filed types Remove unused supportsPaging Squashed 'src/main/resources/csl-styles/' changes from 5c376b8..f4399aa Fix more 404 links Fix custom theme styles not applied to the entry preview (JabRef#7071) Fix Shared Database Tests (JabRef#7040) Bump byte-buddy-parent from 1.10.17 to 1.10.18 (JabRef#7059) ... # Conflicts: # src/main/java/org/jabref/gui/DefaultInjector.java
DominikVoigt
deleted the
feature/add-abstract-field-to-complex-search
branch
February 11, 2021 15:35
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the abstract field as a fielded term for complex queries and implements it for the existing complex search fetchers that support abstract field based filtering.