Streamline logging #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -293,7 +294,7 @@ public BasePanel(JabRefFrame frame, BibtexDatabase db, File file, | |||
| fileMonitorHandle = Globals.fileUpdateMonitor.addUpdateListener(this, | |||
| file); | |||
| } catch (IOException ex) { | |||
| BasePanel.logger.warning(ex.toString()); | |||
| LOGGER.debug("Could not register FileUpdateMonitor", ex); | |||
There was a problem hiding this comment.
shouldn't this be LOGGER.warn instead of LOGGER.debug?
There was a problem hiding this comment.
The log levels and practices of commons.logging and java.util.logging are somewhat different. Since I converted the whole thing to commons, I tried to follow their guidelines. In many cases, such as the above, it is quite hard for me to decide the criticality of the event, and, hence, the log level. If you know that this event is really that critical, it is no problem to change the logging. Should I do that? Perhaps ``LOGGER.error` would also be appropriate?
And add a few serialVersionUIDs on the fly :)
… is needed there before initalizing Globals.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request streamlines the usage of logging APIs in JabRef. All direct usages of
java.util.loggingare now replaced by usages ofcommons.logging. Internally,commons.loggingis configured to default tojava.util.logging, so nothing is fundamentally changed.java.util.loggingis still needed in a single class,CacheableHandler, to access the actual log for display in the UI. This is not possible directly withcommons.loggingand requires the usage of the underlying logging API.The major benefits are of this pull request are: