Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support to explore citation relations #7160

Closed
wants to merge 118 commits into from
Closed

Added support to explore citation relations #7160

wants to merge 118 commits into from

Conversation

timbachmann
Copy link
Contributor

@timbachmann timbachmann commented Dec 4, 2020 •
edited by koppor
Loading

Fixes #6187

Added tab in entry editor to explore citation relations of a specific article.
For further information, one can read our project documentation, which is part of this pull request.
This project is part of the "Software Engineering" course at Universität Basel, so don't hesitate to comment or suggest changes.

Screenshots:

Citation Relations Tab

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

marcelluethi and others added 30 commits September 3, 2020 08:36
@marcelluethi
disabled github actions
fedf4c5
@marcelluethi
add clarification to README
c241115
@marcelluethi
add patterns for emacs temp files
d0551c3
@marcelluethi
delete all github workflow files
8e265fa
@timbachmann
Created prototype of an Citation Relations Tab displaying an articles…
3da40dd 
… citation relations based on the currently selected BibEntry.

Created prototype for api fetcher of citation relations.
@timbachmann
Added functionality to disable citation relations tab in settings and…
6e88547 
… added language support (german and english) for tab
@timbachmann
Added basic implementation of opencitations api to CitationRelationsTab
411b50f
@timbachmann
Restructured prototype to search in background and implemented basic …
d739bcd 
…title search for all DOI's
@timbachmann
Added custom ListView for CitationRelationsTab and fixed fetching for…
50608a7 
… articles
@timbachmann
Changed ListView cell of CitationRelationsTab to be responsive and ad…
68fb270 
…ded functionality to addButton and detailsButton
@timbachmann
Changed Layout of CitationRelationsTab to display refresh button and …
c6de773 
…labels responsive
@timbachmann
Code cleanup and Documentation for all new methods and classes
1115b92
@timbachmann
added internet connection loss handling
f72a30e
@timbachmann
added InformationDialog when current entry has no DOI to search
400207f
@timbachmann
added label to progress indicator to show detailed progress infos
77021f5
@RaphaelKreft
resolve merge conflicts
017e5d9
@timbachmann
Implemented WebSearch into CitationRelationsTab
4000d9b
@RaphaelKreft
resolve merge conficts
718fbb5
@timbachmann
Fixed wrong import of Globals
53a12ce
@timbachmann
Added StandardFields CITED and CITEDBY and support for importing slel…
a154b1e 
…ected entries
@timbachmann
Switched Tab Lists
d5e1134
@RaphaelKreft
local Globals bugfix
971b47c
@RaphaelKreft
Merge branch 'prototype' of github-unibas:RaphaelKreft/jabref into pr…
995f071 
…ototype
@RaphaelKreft
Change current dialogpromts to notifications from the bottom
6a9d3c9
@RaphaelKreft
switch vboxes
f5d1065
@RaphaelKreft
Added new Activation Preference, ActivationPane and distinction in bi…
016503b 
…ndToEntry
@RaphaelKreft
style ActivationPane
082a4bf
@timbachmann
added listViews for local search
ab349c0
@timbachmann
support to cancel background task
02e1caa
@RaphaelKreft
Added Localization
def7bcf
@koppor
Copy link
Member

koppor commented Dec 8, 2020

For auto closing: Fixes #6187

(GitHub does not know Resolved issue for auto closing)

@koppor
Copy link
Member

koppor commented Dec 8, 2020

Small note: The commit messages of the new commits are good ones - imperative voice. See https://chris.beams.io/posts/git-commit/#imperative for details

@koppor
Copy link
Member

koppor commented Dec 21, 2020

@timbachmann May I ask for the status? I currently don't see where the current working token is located. 😇

@stefan-kolb
Copy link
Member

@timbachmann Amazing feature ❤️

@koppor
Copy link
Member

koppor commented Jan 10, 2021 •
edited
Loading

Storing references externally

Pro storing "cited by" and "cites" from "external papers" (== not contained in .bib file) into the file

  • .bib file is self contained

Con storing in the file

  • can be retrieved quite easily on another machine
  • bib file pollution

Storing internal references

Internal links within the .bib file:

Pro and con as above

Conclusion

Proposal:

Use a h2 database for storing this information. h2 functionality is already included in JabRef.

NOT chosen:

  • Create a file next to the .bib file with .jabref having meta data of the paper
    • Use YAML as format

Future Work (not part of this PR)

Make a "portable" .car file being self-contained. This is a "citation-archive" containing the external link file and the .bib file. This can be imported by another jabref instance.

@koppor koppor mentioned this pull request Jan 18, 2021
Open
@koppor koppor marked this pull request as draft January 21, 2021 23:27
@koppor koppor mentioned this pull request Mar 1, 2021
Closed
@tobiasdiez tobiasdiez added the status: changes required Pull requests that are not yet complete label Mar 10, 2021
koppor and others added 4 commits July 28, 2021 22:27
@koppor
Merge remote-tracking branch 'origin/main' into pr-7160
08229f1 
# Conflicts:
#	.mailmap
#	AUTHORS
#	src/main/java/org/jabref/gui/entryeditor/EntryEditor.java
#	src/main/java/org/jabref/gui/entryeditor/OtherFieldsTab.java
#	src/main/resources/l10n/JabRef_de.properties
#	src/main/resources/l10n/JabRef_en.properties
@koppor @calixtus
Compile fix
0821f46 
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
@koppor
Modernize code, rename CITEDBY to CITED_BY
24bd884
@koppor
Rename CITEDBY to CITED_BY, began to rework code
5637a4f
@koppor koppor self-assigned this Aug 2, 2021
@koppor koppor mentioned this pull request Sep 22, 2021
Closed
@koppor
Copy link
Member

koppor commented Sep 22, 2021

@koppor koppor mentioned this pull request Sep 22, 2021
Closed
@koppor koppor mentioned this pull request Aug 13, 2022
Merged
6 tasks
@koppor koppor mentioned this pull request Oct 14, 2022
Open
3 tasks
@koppor koppor mentioned this pull request Oct 24, 2022
Open
@koppor koppor mentioned this pull request May 7, 2023
Closed
@koppor
Copy link
Member

koppor commented May 7, 2023

We all did not find time to finish this PR. Therefore, moving to koppor - to preserve the commits. See koppor#643

@koppor koppor closed this May 7, 2023
@HoussemNasri HoussemNasri mentioned this pull request Sep 4, 2023
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaphaelKreft RaphaelKreft RaphaelKreft left review comments

@oliviermattmann oliviermattmann oliviermattmann left review comments

@matiascg matiascg matiascg left review comments

@tobiasdiez tobiasdiez tobiasdiez requested changes

@koppor koppor koppor requested changes

@Siedlerchr Siedlerchr Siedlerchr requested changes

Assignees

@koppor koppor

Labels
entry-editor status: changes required Pull requests that are not yet complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add posibility to explore citation relations
10 participants
@timbachmann @tobiasdiez @koppor @stefan-kolb @Siedlerchr @matiascg @oliviermattmann @RaphaelKreft @ThiloteE @marcelluethi