Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump classgraph from 4.8.92 to 4.8.93 #7166

Merged

Conversation

dependabot[bot]
Copy link
Contributor

@dependabot dependabot bot commented on behalf of github Dec 7, 2020

Bumps classgraph from 4.8.92 to 4.8.93.

Release notes

Sourced from classgraph's releases.

classgraph-4.8.93

A few changes to classloading:

  1. If .overrideClassLoaders(...) or .overrideClasspath(...) is called before .scan(), then only the overrides are used (ClassGraph will not fall back to trying any other known classloaders). This might break things for some users, but it matches the expectation that should have been conveyed by the API.
  2. If you run a scan inside a scan, and you call .overrideClassLoaders(MyClass.class.getClassLoader()), where MyClass was itself loaded by ClassGraph in the outer scan, using scanResult.getClassInfo("mypackage.MyClass").loadClass(), then the override classloader is actually an instance of ClassGraphClassLoader. This was not supported before, but it supported now as of this release. If you use this, then any classloading in the inner scan will first try loading classes with the ClassGraphClassLoader instance from the outer scan, and if that fails, then the inner scan's ClassGraphClassLoader will be tried. This is to allow for classes to be compatible between the outer scan and the inner scan, in cases where both scans find the same classes. (Classes that are identical but were loaded by different classloaders are not seen by the JRE as being the same class.) (#485, thanks to @TheSpiritXIII for the bug report.)
Commits
  • 441713f [maven-release-plugin] prepare release classgraph-4.8.93
  • 5954fe7 Allow overrideClassLoaders(ClassGraphClassLoader) (#485)
  • 012e6c3 Make ClassGraph extend URLClassLoader (#485)
  • b32aa0f Clean up classloader delegation logic
  • c77fbff Update previous commit
  • 3eda4b1 If overrideClassLoaders is set, don't try other classloaders
  • 16a53f6 Don't call findLoadedClass, it's the job of loadClass, not findClass
  • cccd8b4 [maven-release-plugin] prepare for next development iteration
  • See full diff in compare view

Dependabot compatibility score

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.


Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

  • @dependabot rebase will rebase this PR
  • @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
  • @dependabot merge will merge this PR after your CI passes on it
  • @dependabot squash and merge will squash and merge this PR after your CI passes on it
  • @dependabot cancel merge will cancel a previously requested merge and block automerging
  • @dependabot reopen will reopen this PR if it is closed
  • @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually

@Siedlerchr Siedlerchr merged commit 7fcf871 into master Dec 7, 2020
@Siedlerchr Siedlerchr deleted the dependabot/gradle/io.github.classgraph-classgraph-4.8.93 branch December 7, 2020 07:07
Siedlerchr added a commit that referenced this pull request Dec 7, 2020
…/org.apache.tika-tika-core-1.25

* upstream/master:
  New Crowdin updates (#7167)
  Bump classgraph from 4.8.92 to 4.8.93 (#7166)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant