Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Changed context menu item order for library tabs #7171

Merged
merged 6 commits into from
Dec 7, 2020
Merged

Changed context menu item order for library tabs #7171

merged 6 commits into from
Dec 7, 2020

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Dec 7, 2020 •
edited
Loading

Fixed ollys rage

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr approved these changes Dec 7, 2020
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@calixtus
Copy link
Member Author

calixtus commented Dec 7, 2020

grafik

DominikVoigt
DominikVoigt approved these changes Dec 7, 2020
View reviewed changes
Copy link
Contributor

@DominikVoigt DominikVoigt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@koppor
Copy link
Member

koppor commented Dec 7, 2020

State before the PR:

grafik

State of firefox:

grafik

@calixtus calixtus merged commit 395d93b into master Dec 7, 2020
@calixtus calixtus deleted the ollys-rage branch December 7, 2020 21:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DominikVoigt DominikVoigt DominikVoigt approved these changes

@koppor koppor koppor approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@calixtus @koppor @Siedlerchr @DominikVoigt