Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed context menu of linked files not updated #7174

Merged
merged 3 commits into from
Dec 9, 2020
Merged

Fixed context menu of linked files not updated #7174

merged 3 commits into from
Dec 9, 2020

Conversation

calixtus
Copy link
Member

@calixtus calixtus commented Dec 9, 2020 •
edited
Loading

Fixes #5777
This should hopefully fix the bug about the context menu.
Can someone please test it with a file download. I just now don't have a proper file link at hand.

grafik

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@calixtus calixtus added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 9, 2020
@Siedlerchr
Copy link
Member

Works fine, for testing you can add the following to the bibtex source:
file = {:https\://www.w3.org/WAI/ER/tests/xhtml/testfiles/resources/pdf/dummy.pdf:URL},

I noticed that it is impossible to add an online file link manually

tobiasdiez
tobiasdiez approved these changes Dec 9, 2020
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code-wise looks good as well.

@tobiasdiez tobiasdiez merged commit d1fb9e2 into master Dec 9, 2020
@tobiasdiez tobiasdiez deleted the fix-5777 branch December 9, 2020 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez approved these changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Context menu of linked file not updated after downloading
3 participants
@calixtus @Siedlerchr @tobiasdiez