Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speedup processResources #7221

Merged
merged 2 commits into from
Dec 21, 2020
Merged

Speedup processResources #7221

merged 2 commits into from
Dec 21, 2020

Conversation

koppor
Copy link
Member

@koppor koppor commented Dec 21, 2020

processResources task was very slow:

$ gradlew processResources
> Configure project :
Project : => 'org.jabref' Java module

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 49s
1 actionable task: 1 executed

Speed up by:

  1. Pointing to the files to be modified directly
  2. Add gradle file system watcher
@ C:\git-repositories\jabref\jabref
$ gradlew --watch-fs -Dorg.gradle.vfs.verbose=true processResources
Watching the file system is an incubating feature.
Received 7 file system events since last build
Virtual file system retained information about 21136 files, 269 directories and 1 missing files since last build

> Configure project :
Project : => 'org.jabref' Java module

Deprecated Gradle features were used in this build, making it incompatible with Gradle 7.0.
Use '--warning-mode all' to show the individual deprecation warnings.
See https://docs.gradle.org/6.5/userguide/command_line_interface.html#sec:command_line_warnings

BUILD SUCCESSFUL in 4s
1 actionable task: 1 up-to-date
Received 11 file system events for current build
Virtual file system retains information about 21136 files, 269 directories and 1 missing files till next build
  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

koppor and others added 2 commits December 21, 2020 17:53
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
Co-authored-by: Dominik Voigt <dominik.ingo.voigt@gmail.com>
@koppor koppor marked this pull request as draft December 21, 2020 19:17
@koppor koppor marked this pull request as ready for review December 21, 2020 20:24
@koppor koppor added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Dec 21, 2020
@Siedlerchr Siedlerchr merged commit c8c1501 into master Dec 21, 2020
@Siedlerchr Siedlerchr deleted the speedup-process-resources branch December 21, 2020 20:53
Siedlerchr added a commit that referenced this pull request Dec 22, 2020
…dtask

* upstream/master:
  Output java error on console, too (#7222)
  Speedup processResources (#7221)
  Fix ClipboardManager <-> Prefs ordering (#7224)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants