Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ACM, Google Scholar, JSTOR #7229

Merged
merged 1 commit into from
Dec 23, 2020
Merged

Conversation

koppor
Copy link
Member

@koppor koppor commented Dec 22, 2020

We cannot get the ACM fetcher working (#5804) nor the Google Scholar (#7075). JSTOR has a traffic limit. Thus, we disabled them.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

@koppor koppor added this to the v5.2 milestone Dec 22, 2020
@tobiasdiez
Copy link
Member

Is the JSTOR fetcher working in principle, and only hits the quota limit after a certain amount of usages? How many per day?

@koppor
Copy link
Member Author

koppor commented Dec 23, 2020 via email

@Siedlerchr
Copy link
Member

Siedlerchr commented Dec 23, 2020

I remember that it worked a while ago. Maybe they require some cookies or whatever to be present.
Edit// They now also use Recaptcha. I tried some access with curl :(

curl https://www.jstor.org/open/search/?Query=au%3A%22Haman%22au%3A%22Medlin%22

@Siedlerchr Siedlerchr merged commit 071f428 into master Dec 23, 2020
@Siedlerchr Siedlerchr deleted the disable-non-working-fetchers branch December 23, 2020 17:17
This was referenced Dec 24, 2020
Siedlerchr added a commit that referenced this pull request Dec 25, 2020
…dtask

* upstream/master:
  add language mapping for chinese
  remove chinese content
  fix hamcrest link
  Add Traditional Chinese (#7240)
  Show development information
  Allow manual trigger of the deployment workflow
  Release v5.2
  Adapt changelog for 5.2 release
  Update external-libraries.md
  checkstyle
  L10n master (#7235)
  fix fetcher architecture test
  Add missing author
  Add error dialog "Problem finding files" (#6842)
  Disable ACM, Google Scholar, JSTOR (#7229)
@koppor koppor added the fetcher label Jan 14, 2021
@koppor koppor mentioned this pull request Jan 14, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants