Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Readd ACM style to csl #7308

Closed
wants to merge 1 commit into from
Closed

Readd ACM style to csl #7308

wants to merge 1 commit into from

Conversation

Siedlerchr
Copy link
Member

@Siedlerchr Siedlerchr commented Jan 7, 2021

JabRef searches this style when opening the preferences

Follow up fix for #7306

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

JabRef searches this style when loading

Follow up fix for #7306
@calixtus
Copy link
Member

calixtus commented Jan 7, 2021

Why the acm style in particular? Could this maybe a config issue?

@koppor
Copy link
Member

koppor commented Jan 7, 2021

Damn, did not see the PR while working on a fix at 8c49600.

@koppor koppor closed this Jan 7, 2021
@koppor koppor deleted the addACmSTyle branch January 7, 2021 12:15
@Siedlerchr
Copy link
Member Author

    URL url = CitationStyle.class.getResource(STYLES_ROOT + "/acm-siggraph.csl");

@koppor
Copy link
Member

koppor commented Jan 7, 2021

Digging deeper:

@Siedlerchr spottet that at #7306 (comment) that

URL url = CitationStyle.class.getResource(STYLES_ROOT + "/acm-siggraph.csl");

It was a decision at #6010 to hard-code one specific .csl file to check whether CSL loading actually works. See especially the file-diff.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants