Auto-approve depend-a-bot-PRs #7332
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tobiasdiez
requested changes
Jan 12, 2021
There was a problem hiding this comment.
Can you please add this to the auto-merge workflow: https://github.com/JabRef/jabref/blob/master/.github/workflows/automerge.yml
tobiasdiez
added
the
status: changes required
tobiasdiez
reviewed
Jan 19, 2021
.github/workflows/automerge.yml
Outdated
| @@ -15,6 +15,11 @@ jobs: | |||
| checkInterval: 13 | |||
| env: | |||
| GITHUB_TOKEN: "${{ secrets.GITHUB_TOKEN }}" | |||
| - name: Auto approve | |||
| uses: hmarr/auto-approve-action@v2.0.0 | |||
| if: github.actor == 'dependabot[bot]' || github.actor == 'dependabot-preview[bot]' && steps.waitforstatuschecks.outputs.status == 'success' | |||
There was a problem hiding this comment.
The first two checks should be for the whole job (and the first is already, see line 8).
There was a problem hiding this comment.
Took me a while to understand the comment. With some patience, I did. fixed.
koppor
added
status: ready-for-review
Siedlerchr
added a commit
that referenced
this pull request
Feb 21, 2021
* upstream/master: Bump pascalgn/automerge-action from v0.13.0 to v0.13.1 (#7445) Auto-approve depend-a-bot-PRs (#7332) Clarify that changelog is user-facing Remove unmaintained AUTHORS file Fixes the issue "Non valid number as font size results in an uncaught exception." (#7438) Zbmath fetcher (#7440) Bump me.champeau.gradle.jmh from 0.5.2 to 0.5.3 (#7444) Bump styfle/cancel-workflow-action from 0.7.0 to 0.8.0 (#7446)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We currently had issues that the
masterbranch gets pushed to accidently or that failing PRs are merged. Thus, we reconfigured the master branch:That leads that #dependabot PRs need to be approved: #7331
This is additional overhead. If we want to keep the protection (which I think, we should to prevent accidental merges causing additional effort), we need auto-approve: https://github.com/hmarr/auto-approve-action
This PR adds this.