Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes regex (again) in PreviewViewer #7352

Merged
merged 1 commit into from
Jan 15, 2021
Merged

Fixes regex (again) in PreviewViewer #7352

merged 1 commit into from
Jan 15, 2021

Conversation

k3KAW8Pnf7mkmdSMPHz27
Copy link
Sponsor Member

Fixes #7344.

Apparently I did not pay enough attention while copy-pasting in Intellij, or checking the method again afterward. See #7073 (review) for the original regex. Note that to reproduce it in the current JabRef you need to have the preview pane open while searching.

Sorry about this one.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

Siedlerchr
Siedlerchr approved these changes Jan 15, 2021
View reviewed changes
Copy link
Member

@Siedlerchr Siedlerchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick follow up fix

@Siedlerchr Siedlerchr merged commit e173764 into JabRef:master Jan 15, 2021
Siedlerchr added a commit that referenced this pull request Jan 15, 2021
@Siedlerchr
Merge remote-tracking branch 'upstream/master' into importerbackgroun…
e21a060 
…dtask

* upstream/master:
  Fix regex (#7352)
  Disable certain fetcher tests on CI (#7348)
  Add date fields (#7334)

# Conflicts:
#	src/main/java/org/jabref/logic/externalfiles/ExternalFilesContentImporter.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unhandled exception when searching with regular expression
2 participants
@k3KAW8Pnf7mkmdSMPHz27 @Siedlerchr