Readd query syntax validation

CHANGELOG.md

@@ -47,6 +47,7 @@ Note that this project **does not** adhere to [Semantic Versioning](http://semve
 - We fixed an issue where the file path is invisible in dark theme. [#7382](https://github.com/JabRef/jabref/issues/7382)
 - We fixed an issue where the secondary sorting is not working for some special fields. [#7015](https://github.com/JabRef/jabref/issues/7015)
 - We fixed an issue where changing the font size makes the font size field too small. [#7085](https://github.com/JabRef/jabref/issues/7085)
+- We fixed an issue where GUI freezes when searching long titles with some characters. [#7411](https://github.com/JabRef/jabref/issues/7411)
 - We fixed an issue with TexGroups on Linux systems, where the modification of an aux-file did not trigger an auto-update for TexGroups. Furthermore, the detection of file modifications is now more reliable. [#7412](https://github.com/JabRef/jabref/pull/7412)
 - We fixed an issue where the Unicode to Latex formatter produced wrong results for characters with a codepoint higher than Character.MAX_VALUE. [#7387](https://github.com/JabRef/jabref/issues/7387)
 

src/main/java/org/jabref/gui/importer/fetcher/WebSearchPane.java

@@ -73,6 +73,14 @@ protected Node createContentPane() {
         // Create text field for query input
         TextField query = SearchTextField.create();
         query.getStyleClass().add("searchBar");
+        query.textProperty().addListener((observable, oldValue, newValue) -> viewModel.validateQueryStringAndGiveColorFeedback(query, newValue));
+        query.focusedProperty().addListener((observable, oldValue, newValue) -> {
+            if (newValue) {
+                viewModel.validateQueryStringAndGiveColorFeedback(query, query.getText());
+            } else {
+                viewModel.setPseudoClassToValid(query);
+            }
+        });
 
         viewModel.queryProperty().bind(query.textProperty());
 

src/main/java/org/jabref/gui/importer/fetcher/WebSearchPaneViewModel.java

@@ -1,6 +1,10 @@
 package org.jabref.gui.importer.fetcher;
 
 import java.util.SortedSet;
+import java.util.concurrent.ExecutorService;
+import java.util.concurrent.Executors;
+import java.util.concurrent.TimeUnit;
+import java.util.regex.Pattern;
 
 import javafx.beans.property.ListProperty;
 import javafx.beans.property.ObjectProperty;
@@ -10,11 +14,15 @@
 import javafx.beans.property.StringProperty;
 import javafx.collections.FXCollections;
 import javafx.collections.ObservableList;
+import javafx.css.PseudoClass;
+import javafx.scene.control.TextField;
+import javafx.scene.control.Tooltip;
 
 import org.jabref.gui.DialogService;
 import org.jabref.gui.StateManager;
 import org.jabref.gui.importer.ImportEntriesDialog;
 import org.jabref.gui.util.BackgroundTask;
+import org.jabref.gui.util.TaskExecutor;
 import org.jabref.logic.importer.ParserResult;
 import org.jabref.logic.importer.SearchBasedFetcher;
 import org.jabref.logic.importer.WebFetchers;
@@ -29,8 +37,11 @@ public class WebSearchPaneViewModel {
     private final ObjectProperty<SearchBasedFetcher> selectedFetcher = new SimpleObjectProperty<>();
     private final ListProperty<SearchBasedFetcher> fetchers = new SimpleListProperty<>(FXCollections.observableArrayList());
     private final StringProperty query = new SimpleStringProperty();
+    private final ExecutorService executor = Executors.newFixedThreadPool(1);
     private final DialogService dialogService;
     private final StateManager stateManager;
+    private final Pattern queryPattern;
+    private final Pattern laxQueryPattern;
 
     public WebSearchPaneViewModel(PreferencesService preferencesService, DialogService dialogService, StateManager stateManager) {
         this.dialogService = dialogService;
@@ -50,6 +61,13 @@ public WebSearchPaneViewModel(PreferencesService preferencesService, DialogServi
             int newIndex = fetchers.indexOf(newFetcher);
             preferencesService.storeSidePanePreferences(preferencesService.getSidePanePreferences().withWebSearchFetcherSelected(newIndex));
         });
+
+        String allowedFields = "((author|abstract|journal|title|year|year-range):\\s?)?";
+        // Either a single word, or a phrase with quotes, or a year-range
+        String allowedTermText = "(((\\d{4}-\\d{4})|(\\w+)|(\"\\w+[^\"]*\"))\\s?)+";
+        queryPattern = Pattern.compile("^(" + allowedFields + allowedTermText + ")+$");
+        String laxFields = "(\\w+:\\s?)?";
+        laxQueryPattern = Pattern.compile("^(" + laxFields + allowedTermText + ")+$");
     }
 
     public ObservableList<SearchBasedFetcher> getFetchers() {
@@ -91,11 +109,62 @@ public void search() {
 
         BackgroundTask<ParserResult> task;
         task = BackgroundTask.wrap(() -> new ParserResult(activeFetcher.performSearch(getQuery().trim())))
-                             .withInitialMessage(Localization.lang("Processing %0", getQuery().trim()));
+                .withInitialMessage(Localization.lang("Processing %0", getQuery().trim()));
         task.onFailure(dialogService::showErrorDialogAndWait);
 
         ImportEntriesDialog dialog = new ImportEntriesDialog(stateManager.getActiveDatabase().get(), task);
         dialog.setTitle(activeFetcher.getName());
         dialogService.showCustomDialogAndWait(dialog);
     }
+
+    public void validateQueryStringAndGiveColorFeedback(TextField querySource, String queryString) {
+        if (!queryString.strip().isBlank() && !isPatternMatched(queryPattern, queryString)) {
+            if (isPatternMatched(laxQueryPattern, queryString)) {
+                setPseudoClassToUnsupported(querySource);
+                querySource.setTooltip(new Tooltip(Localization.lang("This query uses unsupported fields.")));
+            } else {
+                setPseudoClassToInvalid(querySource);
+                querySource.setTooltip(new Tooltip(Localization.lang("This query uses unsupported syntax.")));
+            }
+        } else if (containsYearAndYearRange(queryString)) {
+            setPseudoClassToInvalid(querySource);
+            querySource.setTooltip(new Tooltip(Localization.lang("The query cannot contain a year and year-range field.")));
+        } else {
+            setPseudoClassToValid(querySource);
+        }
+    }
+
+    private void setPseudoClassToUnsupported(TextField querySource) {
+        querySource.pseudoClassStateChanged(PseudoClass.getPseudoClass("invalid"), false);
+        querySource.pseudoClassStateChanged(PseudoClass.getPseudoClass("unsupported"), true);
+    }
+
+    public void setPseudoClassToValid(TextField querySource) {
+        querySource.pseudoClassStateChanged(PseudoClass.getPseudoClass("invalid"), false);
+        querySource.pseudoClassStateChanged(PseudoClass.getPseudoClass("unsupported"), false);
+    }
+
+    private void setPseudoClassToInvalid(TextField querySource) {
+        querySource.pseudoClassStateChanged(PseudoClass.getPseudoClass("invalid"), true);
+    }
+
+    private boolean containsYearAndYearRange(String queryString) {
+        return queryString.toLowerCase().contains("year:") && queryString.toLowerCase().contains("year-range:");
+    }
+
+    // Use Thread Pool to control the match time
+    private boolean isPatternMatched(Pattern pattern, String queryString) {
+        boolean isMatched = true;
+
+        try {
+            BackgroundTask.wrap(() -> pattern.matcher(queryString.strip()).matches())
+                          .executeWith((TaskExecutor) executor)
+                          .get(1000 * 10, TimeUnit.MILLISECONDS);
+        } catch (Exception e) {
+            isMatched = false;
+        }
+
+        executor.shutdown();
+        return isMatched;
+    }
 }

src/main/resources/l10n/JabRef_en.properties

@@ -2258,6 +2258,9 @@ Remove\ redundant\ spaces=Remove redundant spaces
 Replaces\ consecutive\ spaces\ with\ a\ single\ space\ in\ the\ field\ content.=Replaces consecutive spaces with a single space in the field content.
 Remove\ digits=Remove digits
 Removes\ digits.=Removes digits.
+The\ query\ cannot\ contain\ a\ year\ and\ year-range\ field.=The query cannot contain a year and year-range field.
+This\ query\ uses\ unsupported\ fields.=This query uses unsupported fields.
+This\ query\ uses\ unsupported\ syntax.=This query uses unsupported syntax.
 
 Presets=Presets