Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix wrong conversion of unicode chars #7419

Merged
merged 5 commits into from
Feb 3, 2021
Merged

Fix wrong conversion of unicode chars #7419

merged 5 commits into from
Feb 3, 2021

Conversation

tmrd993
Copy link
Contributor

@tmrd993 tmrd993 commented Feb 3, 2021 •
edited
Loading

Fixes #7387
Fixed the wrong conversion of unicode characters with a codepoint higher than the max value of the primitive type char in the unicode to latex formatter.

  • Change in CHANGELOG.md described (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

tobiasdiez
tobiasdiez requested changes Feb 3, 2021
View reviewed changes
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot! Can you please also add a test that verifies that everything is working now.

src/main/java/org/jabref/logic/util/strings/HTMLUnicodeConversionMaps.java Outdated
@@ -760,7 +760,8 @@
{"64259", "", "ffi"}, // ffi ligature (which LaTeX solves by itself)
{"64260", "", "ffl"}, // ffl ligature (which LaTeX solves by itself)
{"119978", "Oscr", "$\\mathcal{O}$"}, // script capital O -- possibly use \mathscr
{"119984", "Uscr", "$\\mathcal{U}$"} // script capital U -- possibly use \mathscr
{"119984", "Uscr", "$\\mathcal{U}$"}, // script capital U -- possibly use \mathscr
{"120598", "", "$\\epsilon}$"} // mathematical italic epsilon U+1D716 -- requires amsmath
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the closing } is too much here.

@tobiasdiez tobiasdiez added the status: changes required Pull requests that are not yet complete label Feb 3, 2021
@Siedlerchr
Copy link
Member

Thanks for analyzing the issue and your fix! LGTM!

@Siedlerchr Siedlerchr merged commit 242a494 into JabRef:master Feb 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tobiasdiez tobiasdiez tobiasdiez requested changes

@Siedlerchr Siedlerchr Siedlerchr approved these changes

Assignees
No one assigned
Labels
status: changes required Pull requests that are not yet complete
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

epsilon symbol in unicode-to-latex not supported
3 participants
@tmrd993 @Siedlerchr @tobiasdiez