Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed freeze for few seconds on DNS timeout in MacOS #7482

Merged
merged 5 commits into from
Mar 4, 2021

Conversation

Ali96kz
Copy link
Contributor

@Ali96kz Ali96kz commented Mar 2, 2021

#7441 Add user name caching, because on mac InetAddress.getLocalHost().getHostName() operation is slow. Problem described here

@Ali96kz Ali96kz changed the title #7083 Improvements for the Entry Preview Freeze for few seconds sometimes, on MacOS Mar 2, 2021
Copy link
Member

@tobiasdiez tobiasdiez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Two suggestions from my side.

@koobs
Copy link

koobs commented Mar 3, 2021

Suggestion:

Improve log message to include

  • the host name that was attempted in lookup
  • The error code/message
  • Suggested course of action, like "Check DNS / name resolution"

These will assist the user in isolating and resolving the root causes.

@Ali96kz
Copy link
Contributor Author

Ali96kz commented Mar 4, 2021

@koobs we show java.net.UnknownHostException in log, that will give us enough information about problem. IMHO it should be a special article on a website that will show jabref users how to solve such a problem. Also, I don't see any warning message mechanism

@Siedlerchr
Copy link
Member

Siedlerchr commented Mar 4, 2021

Like the idea, an error message could be indeed improved. Regarding info, I would link to a help page under https://docs.jabref.org/

Please have a look at the checkstyle issues. You can import JabRef's code style into intellij and then use the formatter
https://devdocs.jabref.org/getting-into-the-code/guidelines-for-setting-up-a-local-workspace#using-jabrefs-code-style

@Siedlerchr Siedlerchr added the status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers label Mar 4, 2021
@calixtus
Copy link
Member

calixtus commented Mar 4, 2021

Thanks for your contribution. Issues by Tobias Diez have been resolved. Checks are green. Code looks good to me. Merging...

@calixtus calixtus changed the title Freeze for few seconds sometimes, on MacOS Fixed freeze for few seconds on DNS timeout in MacOS Mar 4, 2021
@calixtus calixtus merged commit 77e8e68 into JabRef:master Mar 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: ready-for-review Pull Requests that are ready to be reviewed by the maintainers
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants