Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show information about the journal (incomplete) #7541

Closed
wants to merge 13 commits into from

Conversation

martinfalke
Copy link
Contributor

This pull request includes partial work completed for the feature described in #6189. On the issue page, a more detailed description of the completed and uncompleted tasks, as well as a proposed way forward, is written. None of the tasks below are complete. Although suggested tests have been outlined in code, these are not runnable as the functionality they intend to test is not implemented on a testable level yet. Optimally, the tests should also be revised after choosing and implementing a way forward for the feature per feedback from JabRef developers on the issue page.

  • Change in CHANGELOG.md described in a way that is understandable for the average user (if applicable)
  • Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • Screenshots added in PR description (for UI changes)
  • Checked documentation: Is the information available and up to date? If not created an issue at https://github.com/JabRef/user-documentation/issues or, even better, submitted a pull request to the documentation repository.

LukasGutenberg and others added 13 commits March 3, 2021 16:11
- added another button for the journal field
- added tooltip for the button
- added a function the button is linked to where we can work on the feature
    - added initial python script to generate JSON from an API call
    - Is currently using Crossref API
- popover implemented and located above assigned button
- ready to display relevant information once implemented
        - Test is outlined and ready to be integrate with code
…tomated

automated test. The examples are written in the tests methods.
…tomated

automated test. The examples are written in the tests methods. This is
related to issue JabRef#6189.
…oading and pre-processing journal data using Scimagojr.
- Fix a mistake in the naming of a new test file
@calixtus
Copy link
Member

@tobiasdiez How should we proceed with this PR?

@tobiasdiez
Copy link
Member

In it's current form, the code sadly doesn't work and one needs quite some energy to finish it. If @martinfalke and his group don't have the time to continue working on this, I would say we close it for now. The code is not lost and we can come back to it at a later time. This PR is definitly a valuable step towards a full implementation.

@calixtus calixtus closed this Oct 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants