-
-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show information about the journal (incomplete) #7541
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- added another button for the journal field - added tooltip for the button - added a function the button is linked to where we can work on the feature
- added initial python script to generate JSON from an API call - Is currently using Crossref API
- popover implemented and located above assigned button - ready to display relevant information once implemented
…up18/jabref into feature-for-issue-JabRef#6189
…as been written for feature JabRef#6189
- Test is outlined and ready to be integrate with code
…tomated automated test. The examples are written in the tests methods.
…tomated automated test. The examples are written in the tests methods. This is related to issue JabRef#6189.
…up18/jabref into feature-for-issue-JabRef#6189
…oading and pre-processing journal data using Scimagojr.
- Fix a mistake in the naming of a new test file
@tobiasdiez How should we proceed with this PR? |
In it's current form, the code sadly doesn't work and one needs quite some energy to finish it. If @martinfalke and his group don't have the time to continue working on this, I would say we close it for now. The code is not lost and we can come back to it at a later time. This PR is definitly a valuable step towards a full implementation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request includes partial work completed for the feature described in #6189. On the issue page, a more detailed description of the completed and uncompleted tasks, as well as a proposed way forward, is written. None of the tasks below are complete. Although suggested tests have been outlined in code, these are not runnable as the functionality they intend to test is not implemented on a testable level yet. Optimally, the tests should also be revised after choosing and implementing a way forward for the feature per feedback from JabRef developers on the issue page.
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)