Added preset for new entry keybindings and reintroduced defaults #7705
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,40 @@ | ||
| package org.jabref.gui.preferences.keybindings.presets; | ||
|
|
||
| import java.util.HashMap; | ||
| import java.util.Map; | ||
|
|
||
| import org.jabref.gui.keyboard.KeyBinding; | ||
|
|
||
| public class NewEntryBindingPreset implements KeyBindingPreset { | ||
|
|
||
| private static final Map<KeyBinding, String> KEY_BINDINGS = new HashMap<>(); | ||
calixtus marked this conversation as resolved.
Show resolved
Hide resolved
|
||
|
|
||
| static { | ||
| // Clear conflicting default presets | ||
| KEY_BINDINGS.put(KeyBinding.PULL_CHANGES_FROM_SHARED_DATABASE, ""); | ||
| KEY_BINDINGS.put(KeyBinding.COPY_PREVIEW, ""); | ||
|
|
||
| // Add new entry presets | ||
| KEY_BINDINGS.put(KeyBinding.NEW_ARTICLE, "Ctrl+shift+A"); | ||
|
There was a problem hiding this comment. to be consistent with the other keybindings, please lowercase the Ctrl |
||
| KEY_BINDINGS.put(KeyBinding.NEW_BOOK, "Ctrl+shift+B"); | ||
| KEY_BINDINGS.put(KeyBinding.NEW_ENTRY, "Ctrl+N"); | ||
| KEY_BINDINGS.put(KeyBinding.NEW_ENTRY_FROM_PLAIN_TEXT, "Ctrl+shift+N"); | ||
| KEY_BINDINGS.put(KeyBinding.NEW_INBOOK, "Ctrl+shift+I"); | ||
| KEY_BINDINGS.put(KeyBinding.NEW_INPROCEEDINGS, "Ctrl+shift+C"); | ||
| KEY_BINDINGS.put(KeyBinding.NEW_MASTERSTHESIS, "Ctrl+shift+M"); | ||
| KEY_BINDINGS.put(KeyBinding.NEW_PHDTHESIS, "Ctrl+shift+T"); | ||
| KEY_BINDINGS.put(KeyBinding.NEW_PROCEEDINGS, "Ctrl+shift+P"); | ||
| KEY_BINDINGS.put(KeyBinding.NEW_TECHREPORT, "Ctrl+shift+R"); | ||
| KEY_BINDINGS.put(KeyBinding.NEW_UNPUBLISHED, "Ctrl+shift+U"); | ||
| } | ||
|
|
||
| @Override | ||
| public String getName() { | ||
| return "New Entries"; | ||
|
There was a problem hiding this comment. I find "new entries" a bit confusing, maybe something longer that better explains the purpose? Should be localized as well. There was a problem hiding this comment. Please make a suggestion. We did not come up with something better yet. There was a problem hiding this comment. Something like "Bindings for creating all entry types"? There was a problem hiding this comment. Remember this is just shown in the small menubutton below the the keybindings table There was a problem hiding this comment. A long text would just repeat information the user already has and would be imho extremely annoying. There was a problem hiding this comment. Yeah, I couldn't find a nice formulation that doesn't include "Bindings". But with "New entries" or "New entry types" it's really not clear what this is doing. |
||
| } | ||
|
|
||
| @Override | ||
| public Map<KeyBinding, String> getKeyBindings() { | ||
| return KEY_BINDINGS; | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think ctrl needs to be lowercase5, otherwise the Mac replacement with option might not work
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have no idea, I just did it like the other keybindings... Could you test this please? Maybe this is an issue with other keys.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I test it now, works fine. ctrl is mapped to cmd