-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLI option to write XMP metadata to pdfs #7814
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Took a quick look into the code.
Co-authored-by: Jonatan Asketorp <2598631+k3KAW8Pnf7mkmdSMPHz27@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks already very good.
Some questions and suggestions.
src/test/java/org/jabref/logic/exporter/XmpPdfExporterTest.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
Co-authored-by: Carl Christian Snethlage <50491877+calixtus@users.noreply.github.com>
* upstream/main: New Crowdin updates (#7843) Refactoring and addition of unit tests (#7597) CLI option to write XMP metadata to pdfs (#7814) Add query validation for web search (#7809) change eclipse default output dir (#7842) Bump lucene-queryparser from 8.8.2 to 8.9.0 (#7835) Bump libreoffice from 7.1.3 to 7.1.4 (#7836) Bump postgresql from 42.2.21 to 42.2.22 (#7839) Bump org.eclipse.jgit (#7838) Bump byte-buddy-parent from 1.11.2 to 1.11.5 (#7837) Bump unoloader from 7.1.3 to 7.1.4 (#7841) Ms Office Export patent author as inventor (#7831) Abbreviation toggle within the JournalEditorViewModel now ignores curly braces (issue #7773) (#7807)
* upstream/main: (26 commits) Add unit test to four test classes (#7651) Fix IEEE test (#7852) New Crowdin updates (#7859) Fix markdown syntax of ADRs add missing l10n (#7857) New Crowdin updates (#7847) Bump mockito-core from 3.11.1 to 3.11.2 (#7856) Bump checkstyle from 8.43 to 8.44 (#7855) Fix for issue #4652: Add Find Unlinked Files Filter based on Date (#7846) Fix for entering a backslash in the custom entry preview dialog (#7851) Fixed INSPIREFetcherTest Fixed TitleFetcherTest Ignore baeldung.com and tldrlegal.com from out link checks New Crowdin updates (#7845) New Crowdin updates (#7843) Refactoring and addition of unit tests (#7597) CLI option to write XMP metadata to pdfs (#7814) Add query validation for web search (#7809) change eclipse default output dir (#7842) Bump lucene-queryparser from 8.8.2 to 8.9.0 (#7835) ...
JabRef can write XMP-metadata pdf-files linked to bib-entries.
This can be used to enrich a publication of one's own with a complete bib-entry so people receiving the pdf can easily include it in their library.
To make it possible to integrate that in a latex workflow, I made that feature available from the command line.
Users can specify the keyword 'all', a set of citekeys or pdf-files (or a mix of them) using the new '-w' CLI-option and JabRef will write XMP metadata to the relevant entries.
pdf-files can be specified by:
CHANGELOG.md
described in a way that is understandable for the average user (if applicable)